Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2170053003: mash: Don't crash when dragging a window to the side. (Closed)

Created:
4 years, 5 months ago by Elliot Glaysher
Modified:
4 years, 5 months ago
Reviewers:
sadrul
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Don't crash when dragging a window to the side. WindowServer::GetTreeWithId can be null in the case of |in_nonclient_area|. It looks like |tree| was used without check in 4d3588cbec. BUG=630402 Committed: https://crrev.com/c0ddac38d03c1d91290494b5f6ee77347dba1505 Cr-Commit-Position: refs/heads/master@{#407181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M services/ui/ws/window_manager_state.cc View 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Elliot Glaysher
I have low confidence in this fix, and it's more to sort of prod at ...
4 years, 5 months ago (2016-07-21 21:22:10 UTC) #4
sadrul
This looks like the right fix, actually (you will notice how we check for a ...
4 years, 5 months ago (2016-07-22 03:29:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170053003/1
4 years, 5 months ago (2016-07-22 17:05:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 17:10:33 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 17:12:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0ddac38d03c1d91290494b5f6ee77347dba1505
Cr-Commit-Position: refs/heads/master@{#407181}

Powered by Google App Engine
This is Rietveld 408576698