Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2170043004: IndexedDB: Rename OpenOrDeleteRequest class to ConnectionRequest (Closed)

Created:
4 years, 5 months ago by jsbell
Modified:
4 years, 4 months ago
Reviewers:
cmumford
CC:
chromium-reviews, darin-cc_chromium.org, jsbell+idb_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IndexedDB: Rename OpenOrDeleteRequest class to ConnectionRequest Better name and it matches the concept in the spec. Committed: https://crrev.com/ef26d19b8d98c55494e5eb9fd70e5a11931de1dc Cr-Commit-Position: refs/heads/master@{#408779}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M content/browser/indexed_db/indexed_db_database.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database.cc View 1 4 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
jsbell
Trivial change to a slightly less terrible name. cmumford@ - what do you think? worth ...
4 years, 5 months ago (2016-07-21 22:19:36 UTC) #4
cmumford
On 2016/07/21 22:19:36, jsbell wrote: > Trivial change to a slightly less terrible name. > ...
4 years, 5 months ago (2016-07-21 23:51:33 UTC) #7
cmumford
lgtm lgtm
4 years, 5 months ago (2016-07-22 17:36:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170043004/1
4 years, 4 months ago (2016-07-29 19:54:51 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/43720) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 4 months ago (2016-07-29 19:56:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170043004/20001
4 years, 4 months ago (2016-07-29 20:26:15 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 22:03:38 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 22:06:35 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ef26d19b8d98c55494e5eb9fd70e5a11931de1dc
Cr-Commit-Position: refs/heads/master@{#408779}

Powered by Google App Engine
This is Rietveld 408576698