Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 217003007: [Ozone] Initialize SurfaceFactoryOzone only in the EGL GLES2 case (Closed)

Created:
6 years, 9 months ago by dnicoara
Modified:
6 years, 9 months ago
Reviewers:
piman
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Visibility:
Public.

Description

[Ozone] Initialize SurfaceFactoryOzone only in the EGL GLES2 case aura_unittests explicitly calls GLSurface::InitializeOneOffForTests in main(). The Ozone platform isn't initialized this early causing a CHECK failure when trying to get SurfaceFactoryOzone. At this point surface creation in unittests is handled by OSMesa, thus we don't need SurfaceFactoryOzone initialized. TBR=piman@chromium.org NOTRY=true TESTS=Ran aura_unittests manually using an Ozone build Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260239

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M ui/gl/gl_surface_ozone.cc View 1 chunk +6 lines, -6 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
dnicoara
6 years, 9 months ago (2014-03-28 19:18:56 UTC) #1
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 9 months ago (2014-03-28 19:22:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/217003007/1
6 years, 9 months ago (2014-03-28 19:25:21 UTC) #3
commit-bot: I haz the power
Change committed as 260239
6 years, 9 months ago (2014-03-28 19:29:50 UTC) #4
piman
https://codereview.chromium.org/217003007/diff/1/ui/gl/gl_surface_ozone.cc File ui/gl/gl_surface_ozone.cc (right): https://codereview.chromium.org/217003007/diff/1/ui/gl/gl_surface_ozone.cc#newcode33 ui/gl/gl_surface_ozone.cc:33: break; actually, should we return false here?
6 years, 9 months ago (2014-03-28 19:57:38 UTC) #5
dnicoara
https://codereview.chromium.org/217003007/diff/1/ui/gl/gl_surface_ozone.cc File ui/gl/gl_surface_ozone.cc (right): https://codereview.chromium.org/217003007/diff/1/ui/gl/gl_surface_ozone.cc#newcode33 ui/gl/gl_surface_ozone.cc:33: break; On 2014/03/28 19:57:38, piman wrote: > actually, should ...
6 years, 9 months ago (2014-03-28 20:30:36 UTC) #6
piman
6 years, 9 months ago (2014-03-28 20:48:56 UTC) #7
Message was sent while issue was closed.
On 2014/03/28 20:30:36, dnicoara wrote:
> https://codereview.chromium.org/217003007/diff/1/ui/gl/gl_surface_ozone.cc
> File ui/gl/gl_surface_ozone.cc (right):
> 
>
https://codereview.chromium.org/217003007/diff/1/ui/gl/gl_surface_ozone.cc#ne...
> ui/gl/gl_surface_ozone.cc:33: break;
> On 2014/03/28 19:57:38, piman wrote:
> > actually, should we return false here?
> 
> As is no since OSMesa uses this path and we need to return true for that.
Maybe
> we should add another case statement for OSMesa then we can return false for
> everything else.

Yeah, I think that's what we want. Explicitly whitelist the ones we support, and
fail the rest.

Powered by Google App Engine
This is Rietveld 408576698