Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 2169993002: [Android] Enable platform mode on more perf bots. (Closed)

Created:
4 years, 5 months ago by rnephew (Reviews Here)
Modified:
4 years, 4 months ago
Reviewers:
sullivan, dtu, jbudorick
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

[Android] Enable platform mode on more perf bots. Enable platorm mode on N5, N5X, and N7 bots. BUG=615157 Committed: https://chromium.googlesource.com/chromium/tools/build/+/b0a4417ce4066c82582d8d28daf4679edcc373e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -29 lines) Patch
M scripts/slave/recipes/android/perf.py View 1 chunk +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json View 3 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json View 3 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json View 3 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json View 3 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json View 3 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json View 3 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json View 3 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json View 3 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json View 3 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/get_perf_test_list_old_data.json View 3 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/missing_device.json View 3 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/src_side_script_fails.json View 3 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.expected/test_failure.json View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
rnephew (Reviews Here)
The first run with the S5 passed. Flipping the bit on more (including a tablet) ...
4 years, 5 months ago (2016-07-21 18:52:37 UTC) #2
sullivan
lgtm but would still really love to see a go/short-design-docs on this
4 years, 5 months ago (2016-07-21 18:54:12 UTC) #3
rnephew (Reviews Here)
On 2016/07/21 18:54:12, sullivan wrote: > lgtm but would still really love to see a ...
4 years, 5 months ago (2016-07-21 19:09:35 UTC) #4
sullivan
Awesome, thanks, this is exactly the type of thing I want to see. On Thu, ...
4 years, 5 months ago (2016-07-21 22:01:49 UTC) #5
dtu
lgtm
4 years, 4 months ago (2016-07-26 23:44:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169993002/1
4 years, 4 months ago (2016-07-27 01:41:39 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/6508)
4 years, 4 months ago (2016-07-27 01:49:09 UTC) #10
jbudorick
lgtm
4 years, 4 months ago (2016-07-27 16:07:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169993002/1
4 years, 4 months ago (2016-07-27 16:07:39 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 16:12:06 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/b0a4417ce4066c82582d...

Powered by Google App Engine
This is Rietveld 408576698