Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2169983002: let line/cubic intersect at four spots (Closed)

Created:
4 years, 5 months ago by caryclark
Modified:
4 years, 5 months ago
Reviewers:
kjlubick
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

let line/cubic intersect at four spots With this, let's update the fuzzer. R=kjlubick@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2169983002 Committed: https://skia.googlesource.com/skia/+/a339bb0d958b0c0c605728d9f0526306c154bde5

Patch Set 1 #

Patch Set 2 : remove the right unneeded test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
M src/pathops/SkDCubicLineIntersection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsOpTest.cpp View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169983002/20001
4 years, 5 months ago (2016-07-21 18:49:02 UTC) #3
kjlubick
lgtm
4 years, 5 months ago (2016-07-21 18:50:37 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 19:28:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a339bb0d958b0c0c605728d9f0526306c154bde5

Powered by Google App Engine
This is Rietveld 408576698