Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3382)

Unified Diff: build/config/ios/rules.gni

Issue 2169973002: Add bundle_deps to ios_{app,framework}_bundle templates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ios-app-bundle-executable
Patch Set: Fix compilation of fat builds. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/mac/base_rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/ios/rules.gni
diff --git a/build/config/ios/rules.gni b/build/config/ios/rules.gni
index 03c401ceb63a2ee4a3f17cc21a99d1deb9840748..9aa244db834e3c715e07e50694258f9f5ac80fc9 100644
--- a/build/config/ios/rules.gni
+++ b/build/config/ios/rules.gni
@@ -158,6 +158,7 @@ template("ios_app_bundle") {
forward_variables_from(invoker,
"*",
[
+ "bundle_deps",
"bundle_extension",
"entitlements_path",
"extra_substitutions",
@@ -240,6 +241,7 @@ template("ios_app_bundle") {
forward_variables_from(invoker,
"*",
[
+ "bundle_deps",
"bundle_extension",
"data_deps",
"entitlements_path",
@@ -387,6 +389,9 @@ template("ios_app_bundle") {
} else {
deps += [ ":$_bundle_data_executable" ]
}
+ if (defined(invoker.bundle_deps)) {
+ deps += invoker.bundle_deps
+ }
if (use_ios_simulator) {
if (!defined(data_deps)) {
@@ -470,6 +475,9 @@ template("ios_app_bundle") {
if (defined(invoker.product_type)) {
assert(invoker.product_type != "", "mark product_type as used")
}
+ if (defined(invoker.bundle_deps)) {
+ assert(invoker.bundle_deps != [], "mark bundle_deps as used")
+ }
}
set_defaults("ios_app_bundle") {
« no previous file with comments | « no previous file | build/config/mac/base_rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698