Issue 216993002: Revert "Inline internal getters for typed arrays & friends."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 216993002: Revert "Inline internal getters for typed arrays & friends." (Closed)

Created:
6 years, 9 months ago by Dmitry Lomov (no reviews)

Modified:
6 years, 9 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "Inline internal getters for typed arrays & friends." This reverts commit r20330 for breaking arm64 nosnap tests. TBR=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20336

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+97 lines, -146 lines)			Patch
M	src/arraybuffer.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+0 lines, -52 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/runtime.h	View	2 chunks	+8 lines, -6 lines	0 comments	Download
M	src/runtime.cc	View	2 chunks	+42 lines, -11 lines	0 comments	Download
M	src/spaces.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/typedarray.js	View	8 chunks	+44 lines, -64 lines	0 comments	Download
M	test/mjsunit/harmony/typedarrays.js	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

Dmitry Lomov (no reviews)

6 years, 9 months ago (2014-03-28 13:34:03 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r20336 (presubmit successful).