Video: Plumb media::VideoFrame color space to cc and GpuMemoryBuffer

Video: Plumb media::VideoFrame color space to cc and GpuMemoryBuffer

In VideoResourceUpdater, populate the cc::TextureMailbox's color space
to get this through to the cc::GLRenderer, where it will be used in
compositing.

In GpuMemoryBufferVideoFramePool, specify the gfx::GpuMemoryBuffer's
color space for scanout after populating it.

BUG=622133
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/f864d5f2f48598e2c53f1aa5986880ca8bfc31f1
Cr-Commit-Position: refs/heads/master@{#407882}

[ccameron, 2016-07-21 20:18:19]

Description was changed from

==========
Video: Plumb media::VideoFrame color space to cc and GpuMemoryBuffer

In VideoResourceUpdater, populate the cc::TextureMailbox's color space
to get this through to the cc::GLRenderer, where it will be used in
compositing.

In GpuMemoryBufferVideoFramePool, specify the gfx::GpuMemoryBuffer's
color space for scanout after populating it.

BUG=622133
==========

to

==========
Video: Plumb media::VideoFrame color space to cc and GpuMemoryBuffer

In VideoResourceUpdater, populate the cc::TextureMailbox's color space
to get this through to the cc::GLRenderer, where it will be used in
compositing.

In GpuMemoryBufferVideoFramePool, specify the gfx::GpuMemoryBuffer's
color space for scanout after populating it.

BUG=622133
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[ccameron, 2016-07-21 20:22:13]

ccameron@chromium.org changed reviewers:
+ hubbe@chromium.org

[ccameron, 2016-07-21 20:22:14]

This should complete the plumbing plumbing part of video correction.

This will specify the color space for YUVVideoDrawQuad, as well as
TextureDrawQuad (or any other path video can go through).

From here, we can update and media::VideoFrame::ColorSpace and gfx::ColorSpace
as needed to add any color features that aren't present yet.

[And, of course, we need to get ICC profiles generated, get GLRenderer to
actually use these, etc]

[ccameron, 2016-07-21 22:07:03]

This removes the uglier elements and leaves VideoFrame::ColorSpace() pulling the
color space out of the metadata. Does this look reasonable to build on top of?

https://codereview.chromium.org/2169913003/diff/20001/ui/gfx/color_space.h
File ui/gfx/color_space.h (right):

https://codereview.chromium.org/2169913003/diff/20001/ui/gfx/color_space.h#ne...
ui/gfx/color_space.h:31: // TODO: Remove these, and replace with more generic
constructors.
This sort-of helps me with some of my hacking/plumbing, so it's nice for me to
keep around for now, is that reasonable?

[hubbe, 2016-07-21 22:12:35]

https://codereview.chromium.org/2169913003/diff/20001/ui/gfx/color_space.cc
File ui/gfx/color_space.cc (right):

https://codereview.chromium.org/2169913003/diff/20001/ui/gfx/color_space.cc#n...
ui/gfx/color_space.cc:18: return gfx::ColorSpace();
Add TODOs?

https://codereview.chromium.org/2169913003/diff/20001/ui/gfx/color_space.h
File ui/gfx/color_space.h (right):

https://codereview.chromium.org/2169913003/diff/20001/ui/gfx/color_space.h#ne...
ui/gfx/color_space.h:31: // TODO: Remove these, and replace with more generic
constructors.
On 2016/07/21 22:07:03, ccameron wrote:
> This sort-of helps me with some of my hacking/plumbing, so it's nice for me to
> keep around for now, is that reasonable?

Sure.

[hubbe, 2016-07-21 22:12:54]

lgtm

forgot the LGTM

[ccameron, 2016-07-26 05:53:35]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-07-26 05:53:35]

The patchset sent to the CQ was uploaded after l-g-t-m from hubbe@chromium.org
Link to the patchset: https://codereview.chromium.org/2169913003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-07-26 05:53:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 05:56:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 05:56:23]

Try jobs failed on following builders:
  linux_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)

[ccameron, 2016-07-26 06:03:17]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2016-07-26 06:03:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 06:05:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 06:05:24]

Try jobs failed on following builders:
  linux_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)

[ccameron, 2016-07-26 17:45:16]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2016-07-26 17:45:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 19:44:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-26 19:47:46]

Description was changed from

==========
Video: Plumb media::VideoFrame color space to cc and GpuMemoryBuffer

In VideoResourceUpdater, populate the cc::TextureMailbox's color space
to get this through to the cc::GLRenderer, where it will be used in
compositing.

In GpuMemoryBufferVideoFramePool, specify the gfx::GpuMemoryBuffer's
color space for scanout after populating it.

BUG=622133
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
Video: Plumb media::VideoFrame color space to cc and GpuMemoryBuffer

In VideoResourceUpdater, populate the cc::TextureMailbox's color space
to get this through to the cc::GLRenderer, where it will be used in
compositing.

In GpuMemoryBufferVideoFramePool, specify the gfx::GpuMemoryBuffer's
color space for scanout after populating it.

BUG=622133
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/f864d5f2f48598e2c53f1aa5986880ca8bfc31f1
Cr-Commit-Position: refs/heads/master@{#407882}
==========

[commit-bot: I haz the power, 2016-07-26 19:47:47]

Patchset 4 (id:??) landed as
https://crrev.com/f864d5f2f48598e2c53f1aa5986880ca8bfc31f1
Cr-Commit-Position: refs/heads/master@{#407882}