third_party/WebKit/LayoutTests/http/tests/media/remove-while-loading.html - Issue 2169893002: Convert text-served* and remove-while* tests to testharness.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/media/remove-while-loading.html

Issue 2169893002: Convert text-served* and remove-while* tests to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 1 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/http/tests/media/remove-while-loading.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/media/remove-while-loading.html b/third_party/WebKit/LayoutTests/http/tests/media/remove-while-loading.html

index 27f23d5a78a39a1b15df71b01dace19fd42d512b..edae717ead0349357033cd3b5250b17e948466b6 100644

--- a/third_party/WebKit/LayoutTests/http/tests/media/remove-while-loading.html

+++ b/third_party/WebKit/LayoutTests/http/tests/media/remove-while-loading.html

@@ -1,18 +1,20 @@

+<!DOCTYPE html>

+<title>Test that removing a media element from the tree while loading does not crash.</title>

+<script src="../resources/testharness.js"></script>

+<script src="../resources/testharnessreport.js"></script>

+<script src="../../media-resources/media-file.js"></script>

-<p>Test that removing a media element from the tree while loading does not crash.</p>

-<script src=../../media-resources/media-file.js></script>

-<!-- TODO(foolip): Convert test to testharness.js. crbug.com/588956

- (Please avoid writing new tests using video-test.js) -->

-<script src=../../media-resources/video-test.js></script>

-waitForEvent('loadedmetadata', function () {

- run("document.body.removeChild(video)");

- endTestLater();

-} );

+async_test(function(t) {

+ var video = document.querySelector("video");

-// Find a supported media file.

-var mediaFile = findMediaFile("video", "content/test");

-var mimeType = mimeTypeForFile(mediaFile);

+ video.onloadedmetadata = t.step_func(function() {

+ document.body.removeChild(video);

+ setTimeout(t.step_func_done(), 100);

+ });

-video.src = "http://127.0.0.1:8000/resources/load-and-stall.cgi?name=../../../media/" + mediaFile + "&mimeType=" + mimeType + "&stallAt=100000";

-</script>

+ var mediaFile = findMediaFile("video", "content/test");

+ var mimeType = mimeTypeForFile(mediaFile);

+ video.src = "http://127.0.0.1:8000/resources/load-and-stall.cgi?name=../../../media/" + mediaFile + "&mimeType=" + mimeType + "&stallAt=100000";

+});

+</script>

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/media/remove-while-loading-expected.txt » ('j') | no next file with comments »