Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: tracing/tracing/metrics/system_health/memory_metric_test.html

Issue 2169873002: [system-health] Track amount of peak malloced memory in V8. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/metrics/system_health/memory_metric_test.html
diff --git a/tracing/tracing/metrics/system_health/memory_metric_test.html b/tracing/tracing/metrics/system_health/memory_metric_test.html
index f70dd2d02680d94aba787264e259cc8c8401266c..16ea7fa45c82911cefd80d94bb62700b7c5b6634 100644
--- a/tracing/tracing/metrics/system_health/memory_metric_test.html
+++ b/tracing/tracing/metrics/system_health/memory_metric_test.html
@@ -371,9 +371,15 @@ tr.b.unittest.testSuite(function() {
var v8Dump = newAllocatorDump(pmdRendererA2, 'v8',
{numerics: {size: 650}});
var isolateDumpA = addChildDump(v8Dump, 'isolate_A');
- addChildDump(isolateDumpA, 'malloc', {numerics: {size: 1 }});
+ addChildDump(isolateDumpA, 'malloc', {numerics: {
petrcermak 2016/07/21 13:11:49 Could you also add one isolate with only "size" an
ulan 2016/07/21 13:47:07 Done.
+ size: 1,
+ peak_size: 2
+ }});
var isolateDumpB = addChildDump(v8Dump, 'isolate_B');
- addChildDump(isolateDumpB, 'malloc', {numerics: {size: 10 }});
+ addChildDump(isolateDumpB, 'malloc', {numerics: {
+ size: 10,
+ peak_size: 20
+ }});
return [partitionAllocDump, v8Dump];
})();
var pmdRendererB2 = addProcessMemoryDump(gmd2, pRendererB, {ts: 40});
@@ -506,6 +512,13 @@ tr.b.unittest.testSuite(function() {
description: 'effective size of objects allocated by malloc for v8 ' +
'in all processes in Chrome'
},
+ 'memory:chrome:all_processes:reported_by_chrome:v8:allocated_by_malloc:peak_size':
+ {
+ value: [0, 2 + 20, 0, 0],
+ unit: sizeInBytes_smallerIsBetter,
+ description: 'peak size of objects allocated by malloc for v8 ' +
+ 'in all processes in Chrome'
+ },
'memory:chrome:all_processes:reported_by_chrome:v8:effective_size': {
value: [0, 650 + 970 + 111, 0, 4e5],
unit: sizeInBytes_smallerIsBetter,
@@ -627,6 +640,13 @@ tr.b.unittest.testSuite(function() {
description: 'effective size of objects allocated by malloc for v8 ' +
'in renderer processes in Chrome'
},
+ 'memory:chrome:renderer_processes:reported_by_chrome:v8:allocated_by_malloc:peak_size':
+ {
+ value: [0, 2 + 20, 0, 0],
+ unit: sizeInBytes_smallerIsBetter,
+ description: 'peak size of objects allocated by malloc for v8 ' +
+ 'in renderer processes in Chrome'
+ },
'memory:chrome:renderer_processes:reported_by_chrome:v8:effective_size': {
value: [0, 650 + 970, 0, 4e5],
unit: sizeInBytes_smallerIsBetter,
@@ -1463,7 +1483,10 @@ tr.b.unittest.testSuite(function() {
size: 67108864
}});
var isolateDump = addChildDump(v8Dump, 'isolate');
- addChildDump(isolateDump, 'malloc', {numerics: {size: 1 }});
+ addChildDump(isolateDump, 'malloc', {numerics: {
+ size: 1,
+ peak_size: 2
+ }});
return [mallocDump, v8Dump];
})();
pmdBrowser6.vmRegions = VMRegionClassificationNode.fromRegions([
@@ -1545,6 +1568,13 @@ tr.b.unittest.testSuite(function() {
description: 'effective size of objects allocated by malloc for v8 ' +
'in all processes in WebView'
},
+ 'memory:webview:all_processes:reported_by_chrome:v8:allocated_by_malloc:peak_size':
+ {
+ value: [0, 2],
+ unit: sizeInBytes_smallerIsBetter,
+ description: 'peak size of objects allocated by malloc for v8 ' +
+ 'in all processes in WebView'
+ },
'memory:webview:all_processes:reported_by_chrome:v8:effective_size': {
value: [4, 67108864],
unit: sizeInBytes_smallerIsBetter,
@@ -1669,6 +1699,13 @@ tr.b.unittest.testSuite(function() {
description: 'effective size of objects allocated by malloc for v8 ' +
'in the browser process in WebView'
},
+ 'memory:webview:browser_process:reported_by_chrome:v8:allocated_by_malloc:peak_size':
+ {
+ value: [0, 2],
+ unit: sizeInBytes_smallerIsBetter,
+ description: 'peak size of objects allocated by malloc for v8 ' +
+ 'in the browser process in WebView'
+ },
'memory:webview:browser_process:reported_by_chrome:v8:effective_size': {
value: [4, 67108864],
unit: sizeInBytes_smallerIsBetter,

Powered by Google App Engine
This is Rietveld 408576698