Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2169863003: Comment on UMA_HISTOGRAM_ENUMERATION that explains an overflow bucket (Closed)

Created:
4 years, 5 months ago by jkrcal
Modified:
4 years, 5 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Comment on UMA_HISTOGRAM_ENUMERATION that explains an overflow bucket The call to base::LinearHistogram::FactoryGet may simply look wrong without the explanation. Committed: https://crrev.com/bb99d1a5a44c994ac3cbc22fff4b89e266ee6e35 Cr-Commit-Position: refs/heads/master@{#407107}

Patch Set 1 #

Patch Set 2 : Polishing the text. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M base/metrics/histogram_macros.h View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
jkrcal
PTAL!
4 years, 5 months ago (2016-07-21 19:38:58 UTC) #2
Alexei Svitkine (slow)
lgtm
4 years, 5 months ago (2016-07-21 20:09:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169863003/20001
4 years, 5 months ago (2016-07-21 20:10:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/248159)
4 years, 5 months ago (2016-07-21 20:49:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169863003/20001
4 years, 5 months ago (2016-07-22 08:36:40 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-22 09:09:29 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 09:11:13 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bb99d1a5a44c994ac3cbc22fff4b89e266ee6e35
Cr-Commit-Position: refs/heads/master@{#407107}

Powered by Google App Engine
This is Rietveld 408576698