Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2169843003: Change initialization of canvas used for Ash material design battery (Closed)

Created:
4 years, 5 months ago by tdanderson
Modified:
4 years, 5 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change initialization of canvas used for Ash material design battery For the Ash material design battery icon seen in the system tray, change the |is_opaque| argument to false when initializing its canvas. This will force a clear and prevents unwanted artifacts from appearing over top of / underneath the icon. BUG=626917 TEST=manual Committed: https://crrev.com/ebaed71d0edd7e63a6197af483c5852eb1c436ca Cr-Commit-Position: refs/heads/master@{#406895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ash/common/system/chromeos/power/power_status.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
tdanderson
James, can you please take a look?
4 years, 5 months ago (2016-07-21 16:49:00 UTC) #4
James Cook
lgtm
4 years, 5 months ago (2016-07-21 17:38:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169843003/1
4 years, 5 months ago (2016-07-21 17:48:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 17:52:23 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 17:54:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ebaed71d0edd7e63a6197af483c5852eb1c436ca
Cr-Commit-Position: refs/heads/master@{#406895}

Powered by Google App Engine
This is Rietveld 408576698