Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2169843002: Rolling DEPS for third_party/ced (Closed)

Created:
4 years, 5 months ago by Jinsuk Kim
Modified:
4 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rolling DEPS for third_party/ced This CL cleans up unnecessary build configuration to facilitate Chrome build. BUG=630113 TEST=gclient sync, make Committed: https://crrev.com/64cb3a3e39bf7972db8b1834a0ab5c23380bc6bb Cr-Commit-Position: refs/heads/master@{#406976}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Jinsuk Kim
4 years, 5 months ago (2016-07-21 10:55:59 UTC) #2
brettw
You can TBR deps rolls since there's no practical way to review your hash anyway. ...
4 years, 5 months ago (2016-07-21 16:47:16 UTC) #3
Jinsuk Kim
On 2016/07/21 16:47:16, brettw (ping on IM after 24h) wrote: > You can TBR deps ...
4 years, 5 months ago (2016-07-21 21:36:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169843002/1
4 years, 5 months ago (2016-07-21 21:38:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 22:45:58 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 22:48:09 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64cb3a3e39bf7972db8b1834a0ab5c23380bc6bb
Cr-Commit-Position: refs/heads/master@{#406976}

Powered by Google App Engine
This is Rietveld 408576698