src/parsing/parser.h - Issue 2169833002: [parser] Refactor AstTraversalVisitor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parsing/parser.h

Issue 2169833002: [parser] Refactor AstTraversalVisitor (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parsing/parser.h

diff --git a/src/parsing/parser.h b/src/parsing/parser.h

index 4ab075e052c48070a5814ab1b5c4dfbf5d57817a..a1c25c47296165b84c1b325af3d01ba9023a0ed6 100644

--- a/src/parsing/parser.h

+++ b/src/parsing/parser.h

@@ -853,7 +853,7 @@ class Parser : public ParserBase<ParserTraits> {

Scanner::Location bindings_loc;

};

- class PatternRewriter final : private AstVisitor<PatternRewriter> {

+ class PatternRewriter final : public AstVisitor<PatternRewriter> {

public:

static void DeclareAndInitializeVariables(

Block* block, const DeclarationDescriptor* declaration_descriptor,

« no previous file with comments | « src/parsing/parameter-initializer-rewriter.cc ('k') | src/parsing/parser.cc » ('j') | no next file with comments »