Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: src/debug/liveedit.h

Issue 2169833002: [parser] Refactor AstTraversalVisitor (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/ast-traversal-visitor.h ('k') | src/debug/liveedit.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/liveedit.h
diff --git a/src/debug/liveedit.h b/src/debug/liveedit.h
index 32328d9da7d9cd3dae2a22b80db725a9518e41dd..ec0f6dfcdeef667b167041ab0d27b4447b553d30 100644
--- a/src/debug/liveedit.h
+++ b/src/debug/liveedit.h
@@ -26,6 +26,7 @@
#include "src/allocation.h"
+#include "src/ast/ast-traversal-visitor.h"
#include "src/compiler.h"
namespace v8 {
@@ -38,7 +39,8 @@ namespace internal {
// in order to analyze whether function code may be safely patched (with new
// code successfully reading existing data from function scopes). The Tracker
// also collects compiled function codes.
-class LiveEditFunctionTracker : public AstTraversalVisitor {
+class LiveEditFunctionTracker
+ : public AstTraversalVisitor<LiveEditFunctionTracker> {
public:
// Traverses the entire AST, and records information about all
// FunctionLiterals for further use by LiveEdit code patching. The collected
@@ -46,8 +48,9 @@ class LiveEditFunctionTracker : public AstTraversalVisitor {
static Handle<JSArray> Collect(FunctionLiteral* node, Handle<Script> script,
Zone* zone, Isolate* isolate);
- virtual ~LiveEditFunctionTracker() {}
- void VisitFunctionLiteral(FunctionLiteral* node) override;
+ protected:
+ friend AstTraversalVisitor<LiveEditFunctionTracker>;
+ void VisitFunctionLiteral(FunctionLiteral* node);
private:
LiveEditFunctionTracker(Handle<Script> script, Zone* zone, Isolate* isolate);
« no previous file with comments | « src/ast/ast-traversal-visitor.h ('k') | src/debug/liveedit.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698