[parser] Refactor AstTraversalVisitor

src/compiler.h

Index: src/compiler.h
diff --git a/src/compiler.h b/src/compiler.h
index e2f71479407bccbd139518236500017f7ae0f121..00e4ba93a8034254720ff92dda83cca3f25db5ba 100644
--- a/src/compiler.h
+++ b/src/compiler.h
@@ -6,6 +6,7 @@
 #define V8_COMPILER_H_
 
 #include "src/allocation.h"
+#include "src/ast/ast-traversal-visitor.h"

[adamk, 2016/07/21 18:11:57]

I don't see AstTraversalVisitor used in this file, why is it included here?

[nickie, 2016/07/22 08:40:18]

Right, it's not used here.  But the AstTraversalVisitor was defined in
src/ast/ast.h, which is included by this header file.  Therefore, if this line
is removed, then it has to be included in src/debug/liveedit.h.  As this file is
already in the patch, I'm making this change.

To make the picture complete, the decision to take the definition of
AstTraversalVisitor out of src/ast/ast.h was more or less a forced one.  When it
became a template, the implementation of its methods had to be in the header
file.  Some of them use the scope object, which is declared but not defined in
src/ast/ast.h.

 #include "src/ast/ast.h"
 #include "src/bailout-reason.h"
 #include "src/compilation-dependencies.h"