The android framework should not embolden glyphs that originate from bold fonts.

The android framework should not embolden glyphs that originate from bold fonts.

Committed: http://code.google.com/p/skia/source/detail?r=14014

[scroggo, 2014-04-01 17:46:23]

https://codereview.chromium.org/216983005/diff/1/src/ports/SkFontHost_FreeTyp...
File src/ports/SkFontHost_FreeType.cpp (right):

https://codereview.chromium.org/216983005/diff/1/src/ports/SkFontHost_FreeTyp...
src/ports/SkFontHost_FreeType.cpp:1513: case FT_GLYPH_FORMAT_OUTLINE:
4 space indents (here and below)

https://codereview.chromium.org/216983005/diff/1/src/ports/SkFontHost_FreeTyp...
src/ports/SkFontHost_FreeType.cpp:1520: FT_Bitmap_Embolden(glyph->library,
&glyph->bitmap, kBitmapEmboldenStrength, 0);
Once you have spacing fixed, this shouldn't be 100 chars anymore.

[djsollen, 2014-04-01 17:55:06]

https://codereview.chromium.org/216983005/diff/1/src/ports/SkFontHost_FreeTyp...
File src/ports/SkFontHost_FreeType.cpp (right):

https://codereview.chromium.org/216983005/diff/1/src/ports/SkFontHost_FreeTyp...
src/ports/SkFontHost_FreeType.cpp:1513: case FT_GLYPH_FORMAT_OUTLINE:
On 2014/04/01 17:46:23, scroggo wrote:
> 4 space indents (here and below)

Done.

[scroggo, 2014-04-01 18:03:15]

lgtm

[djsollen, 2014-04-01 18:06:05]

The CQ bit was checked by djsollen@google.com

[commit-bot: I haz the power, 2014-04-01 18:06:15]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/djsollen@google.com/216983005/40001

[bungeman-skia, 2014-04-01 18:13:01]

lgtm for now. We should go through all users of this interface and standardize
on this flag always 'fake bolding' since in the future we won't have a hard
'bold' level.

https://codereview.chromium.org/216983005/diff/40001/src/ports/SkFontHost_Fre...
File src/ports/SkFontHost_FreeType.cpp (right):

https://codereview.chromium.org/216983005/diff/40001/src/ports/SkFontHost_Fre...
src/ports/SkFontHost_FreeType.cpp:1501: if (0 == (fRec.fFlags &
SkScalerContext::kEmbolden_Flag)) {
nit: you could also use SkToBool(...) here.

[commit-bot: I haz the power, 2014-04-01 19:03:12]

Change committed as 14014