content/shell/renderer/test_runner/WebPermissions.h - Issue 216983003: Chrome side changes to removing WebFrame parameter from WebPermissionClient, since it's redundant n…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/test_runner/WebPermissions.h

Issue 216983003: Chrome side changes to removing WebFrame parameter from WebPermissionClient, since it's redundant n… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/content_settings_observer.h ('K') | « chrome/renderer/content_settings_observer.cc ('k') | content/shell/renderer/test_runner/WebPermissions.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/test_runner/WebPermissions.h

===================================================================

--- content/shell/renderer/test_runner/WebPermissions.h (revision 260883)

+++ content/shell/renderer/test_runner/WebPermissions.h (working copy)

@@ -18,6 +18,7 @@

virtual ~WebPermissions();

// Override WebPermissionClient methods.

+ // TODO(jam): remove all these methods after Blink rolls.

virtual bool allowImage(blink::WebFrame*, bool enabledPerSettings, const blink::WebURL& imageURL);

virtual bool allowScriptFromSource(blink::WebFrame*, bool enabledPerSettings, const blink::WebURL& scriptURL);

virtual bool allowStorage(blink::WebFrame*, bool local);

@@ -25,6 +26,13 @@

virtual bool allowDisplayingInsecureContent(blink::WebFrame*, bool enabledPerSettings, const blink::WebSecurityOrigin&, const blink::WebURL&);

virtual bool allowRunningInsecureContent(blink::WebFrame*, bool enabledPerSettings, const blink::WebSecurityOrigin&, const blink::WebURL&);

+ virtual bool allowImage(bool enabledPerSettings, const blink::WebURL& imageURL);

+ virtual bool allowScriptFromSource(bool enabledPerSettings, const blink::WebURL& scriptURL);

+ virtual bool allowStorage(bool local);

+ virtual bool allowPlugins(bool enabledPerSettings);

+ virtual bool allowDisplayingInsecureContent(bool enabledPerSettings, const blink::WebSecurityOrigin&, const blink::WebURL&);

+ virtual bool allowRunningInsecureContent(bool enabledPerSettings, const blink::WebSecurityOrigin&, const blink::WebURL&);

// Hooks to set the different policies.

void setImagesAllowed(bool);

void setScriptsAllowed(bool);