FunctionState doesn't need to know AstNodeFactory.

FunctionState doesn't need to know AstNodeFactory.

It's anyway just the "same" AstNodeFactory (i.e., it's passed the same
AstValueFactory), so no need to have several of them for each
FunctionState.

R=verwaest@chromium.org
BUG=

Committed: https://crrev.com/17376b6d856f4949d6c46dc811cd48af6571db44
Cr-Commit-Position: refs/heads/master@{#37938}

[marja, 2016-07-21 09:14:26]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 09:14:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 09:17:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 09:17:44]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/9470)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/9416)

[marja, 2016-07-21 09:35:01]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 09:35:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2016-07-21 09:57:18]

ptal

In some code paths, we haven't created AstValueFactory before calling
ParserBase::ParserBase; it's unfortunate that we need to reset the
AstValueFactory of AstNodeFactory in that code path. But I can't think of
anything cleaner... this way at least AstNodeFactory becomes a member of
ParserBase (so it's auto-deleted), and changing that would then introduce mess
in other parts of the code.

[commit-bot: I haz the power, 2016-07-21 09:58:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 09:58:03]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2016-07-21 10:56:55]

lgtm

[marja, 2016-07-21 10:59:15]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2016-07-21 10:59:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 11:03:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-21 11:06:26]

Description was changed from

==========
FunctionState doesn't need to know AstNodeFactory.

It's anyway just the "same" AstNodeFactory (i.e., it's passed the same
AstValueFactory), so no need to have several of them for each
FunctionState.

R=verwaest@chromium.org
BUG=
==========

to

==========
FunctionState doesn't need to know AstNodeFactory.

It's anyway just the "same" AstNodeFactory (i.e., it's passed the same
AstValueFactory), so no need to have several of them for each
FunctionState.

R=verwaest@chromium.org
BUG=

Committed: https://crrev.com/17376b6d856f4949d6c46dc811cd48af6571db44
Cr-Commit-Position: refs/heads/master@{#37938}
==========

[commit-bot: I haz the power, 2016-07-21 11:06:27]

Patchset 2 (id:??) landed as
https://crrev.com/17376b6d856f4949d6c46dc811cd48af6571db44
Cr-Commit-Position: refs/heads/master@{#37938}