test/unittests/interpreter/bytecode-array-builder-unittest.cc - Issue 2169813002: [interpreter] Add output register to ToName

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/interpreter/bytecode-array-builder-unittest.cc

Issue 2169813002: [interpreter] Add output register to ToName (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@addregouts

Patch Set: remove and inline BuildCastOperator Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/unittests/interpreter/bytecode-array-builder-unittest.cc

diff --git a/test/unittests/interpreter/bytecode-array-builder-unittest.cc b/test/unittests/interpreter/bytecode-array-builder-unittest.cc

index e13294de7603c797a6b11be323a9202f693e1b3c..f83ede0e5b817c4961ff88f31bddffc1b4524319 100644

--- a/test/unittests/interpreter/bytecode-array-builder-unittest.cc

+++ b/test/unittests/interpreter/bytecode-array-builder-unittest.cc

@@ -182,7 +182,7 @@ TEST_F(BytecodeArrayBuilderTest, AllBytecodesGenerated) {

// Emit cast operator invocations.

builder.CastAccumulatorToNumber(reg)

.CastAccumulatorToJSObject()

- .CastAccumulatorToName();

+ .CastAccumulatorToName(reg);

// Emit control flow. Return must be the last instruction.

BytecodeLabel start;