Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1378)

Unified Diff: src/interpreter/mkpeephole.cc

Issue 2169813002: [interpreter] Add output register to ToName (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@addregouts
Patch Set: remove and inline BuildCastOperator Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/mkpeephole.cc
diff --git a/src/interpreter/mkpeephole.cc b/src/interpreter/mkpeephole.cc
index d89390d45d125f9ca2d6dfaf619ce911794bdcb6..482823abb2af602ee8f51727100690830828cc8c 100644
--- a/src/interpreter/mkpeephole.cc
+++ b/src/interpreter/mkpeephole.cc
@@ -109,10 +109,10 @@ PeepholeActionAndData PeepholeActionTableWriter::LookupActionAndData(
// ToName optimizations: remove unnecessary ToName bytecodes.
oth 2016/07/22 11:13:10 Can this comment be updated to reflect the new sem
klaasb 2016/07/25 12:25:08 Done.
if (current == Bytecode::kToName) {
if (last == Bytecode::kLdaConstant) {
- return {PeepholeAction::kElideCurrentIfLoadingNameConstantAction,
+ return {PeepholeAction::kTransformToStarIfLoadingNameConstantAction,
Bytecode::kIllegal};
} else if (Bytecodes::PutsNameInAccumulator(last)) {
- return {PeepholeAction::kElideCurrentAction, Bytecode::kIllegal};
+ return {PeepholeAction::kChangeBytecodeAction, Bytecode::kStar};
}
}

Powered by Google App Engine
This is Rietveld 408576698