Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Unified Diff: src/interpreter/bytecode-array-builder.h

Issue 2169813002: [interpreter] Add output register to ToName (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@addregouts
Patch Set: remove and inline BuildCastOperator Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/bytecode-array-builder.h
diff --git a/src/interpreter/bytecode-array-builder.h b/src/interpreter/bytecode-array-builder.h
index 92d1b92e85bc798b1972bebdab9544b38a637282..627144f9aa40aef296b722cbe4526d2f04c347e9 100644
--- a/src/interpreter/bytecode-array-builder.h
+++ b/src/interpreter/bytecode-array-builder.h
@@ -214,7 +214,8 @@ class BytecodeArrayBuilder final : public ZoneObject {
// Casts.
BytecodeArrayBuilder& CastAccumulatorToBoolean();
BytecodeArrayBuilder& CastAccumulatorToJSObject();
- BytecodeArrayBuilder& CastAccumulatorToName();
+ // Does not update the accumulator but stores to |out| instead.
rmcilroy 2016/07/25 10:57:47 nit - could you have two separate headings and rem
klaasb 2016/07/25 12:25:08 Done.
+ BytecodeArrayBuilder& CastAccumulatorToName(Register out);
// Does not update the accumulator but stores to |out| instead.
BytecodeArrayBuilder& CastAccumulatorToNumber(Register out);

Powered by Google App Engine
This is Rietveld 408576698