src/interpreter/bytecode-array-builder.h - Issue 2169813002: [interpreter] Add output register to ToName

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecode-array-builder.h

Issue 2169813002: [interpreter] Add output register to ToName (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@addregouts

Patch Set: fix unittests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/interpreter/bytecode-array-builder.h

diff --git a/src/interpreter/bytecode-array-builder.h b/src/interpreter/bytecode-array-builder.h

index 6b4c5d2e0f719c31462819bc90efefa61ab4e16d..a55129a58cc4db3705e6b98057af42e7f423956d 100644

--- a/src/interpreter/bytecode-array-builder.h

+++ b/src/interpreter/bytecode-array-builder.h

@@ -214,7 +214,8 @@ class BytecodeArrayBuilder final : public ZoneObject {

// Casts.

BytecodeArrayBuilder& CastAccumulatorToBoolean();

BytecodeArrayBuilder& CastAccumulatorToJSObject();

- BytecodeArrayBuilder& CastAccumulatorToName();

+ // Does not update the accumulator but stores to the register operand instead.

+ BytecodeArrayBuilder& CastAccumulatorToName(Register out);

// Does not update the accumulator but stores to the register operand instead.

BytecodeArrayBuilder& CastAccumulatorToNumber(Register out);