Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2169803002: Remove HTMLLinkElement::m_isInShadowTree member variable (Closed)

Created:
4 years, 5 months ago by hayato
Modified:
4 years, 5 months ago
Reviewers:
tkent, kochi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, gavinp+prerender_chromium.org, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove HTMLLinkElement::m_isInShadowTree member variable This member variable can be removed without any behavior change. BUG=630141 Committed: https://crrev.com/337e2547babe2c6a27130ad593de52f730848b74 Cr-Commit-Position: refs/heads/master@{#406807}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M third_party/WebKit/Source/core/html/HTMLLinkElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
hayato
PTAL
4 years, 5 months ago (2016-07-21 08:04:50 UTC) #5
tkent
lgtm
4 years, 5 months ago (2016-07-21 08:24:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169803002/1
4 years, 5 months ago (2016-07-21 08:43:51 UTC) #9
kochi
lgtm
4 years, 5 months ago (2016-07-21 09:04:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 09:14:13 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 09:17:02 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/337e2547babe2c6a27130ad593de52f730848b74
Cr-Commit-Position: refs/heads/master@{#406807}

Powered by Google App Engine
This is Rietveld 408576698