Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1148)

Unified Diff: chrome/browser/android/data_usage/external_data_use_reporter.cc

Issue 2169773002: Batch data use objects in ExternalDataUseObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/data_usage/external_data_use_reporter.cc
diff --git a/chrome/browser/android/data_usage/external_data_use_reporter.cc b/chrome/browser/android/data_usage/external_data_use_reporter.cc
index 898a7cbe485388776e0531c15ae2837a965f9b03..f47d94ccc620516e1325ea22c71f5238fc5974f5 100644
--- a/chrome/browser/android/data_usage/external_data_use_reporter.cc
+++ b/chrome/browser/android/data_usage/external_data_use_reporter.cc
@@ -130,20 +130,25 @@ ExternalDataUseReporter::~ExternalDataUseReporter() {
DCHECK(thread_checker_.CalledOnValidThread());
}
-void ExternalDataUseReporter::OnDataUse(const data_usage::DataUse& data_use) {
+void ExternalDataUseReporter::OnDataUse(
+ std::unique_ptr<const std::deque<const data_usage::DataUse>>
+ data_use_list) {
DCHECK(thread_checker_.CalledOnValidThread());
+ DCHECK(data_use_list);
const base::Time now_time = base::Time::Now();
DataUseTabModel::TrackingInfo tracking_info;
- if (!data_use_tab_model_->GetTrackingInfoForTabAtTime(
- data_use.tab_id, data_use.request_start, &tracking_info)) {
- return;
- }
+ for (const auto& data_use : *data_use_list) {
+ if (!data_use_tab_model_->GetTrackingInfoForTabAtTime(
+ data_use.tab_id, data_use.request_start, &tracking_info)) {
+ continue;
+ }
- BufferDataUseReport(data_use, tracking_info.label, tracking_info.tag,
- previous_report_time_, now_time);
- SubmitBufferedDataUseReport(false);
+ BufferDataUseReport(data_use, tracking_info.label, tracking_info.tag,
+ previous_report_time_, now_time);
+ SubmitBufferedDataUseReport(false);
+ }
previous_report_time_ = now_time;
}

Powered by Google App Engine
This is Rietveld 408576698