Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Side by Side Diff: chrome/browser/android/data_usage/external_data_use_reporter_unittest.cc

Issue 2169773002: Batch data use objects in ExternalDataUseObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/android/data_usage/external_data_use_reporter.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/data_usage/external_data_use_reporter.h" 5 #include "chrome/browser/android/data_usage/external_data_use_reporter.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 120
121 // Returns a default data_usage::DataUse object. 121 // Returns a default data_usage::DataUse object.
122 data_usage::DataUse default_data_use() { 122 data_usage::DataUse default_data_use() {
123 return data_usage::DataUse( 123 return data_usage::DataUse(
124 GURL(kDefaultURL), base::TimeTicks::Now(), GURL(), kDefaultTabId, 124 GURL(kDefaultURL), base::TimeTicks::Now(), GURL(), kDefaultTabId,
125 net::NetworkChangeNotifier::CONNECTION_UNKNOWN, "", 125 net::NetworkChangeNotifier::CONNECTION_UNKNOWN, "",
126 default_upload_bytes(), default_download_bytes()); 126 default_upload_bytes(), default_download_bytes());
127 } 127 }
128 128
129 void OnDataUse(const data_usage::DataUse& data_use) { 129 void OnDataUse(const data_usage::DataUse& data_use) {
130 external_data_use_reporter()->OnDataUse(data_use); 130 std::unique_ptr<std::deque<const data_usage::DataUse>> data_use_list(
131 new std::deque<const data_usage::DataUse>());
132 data_use_list->push_back(data_use);
133 external_data_use_reporter()->OnDataUse(std::move(data_use_list));
131 } 134 }
132 135
133 ExternalDataUseObserver* external_data_use_observer() const { 136 ExternalDataUseObserver* external_data_use_observer() const {
134 return external_data_use_observer_.get(); 137 return external_data_use_observer_.get();
135 } 138 }
136 139
137 ExternalDataUseReporter* external_data_use_reporter() const { 140 ExternalDataUseReporter* external_data_use_reporter() const {
138 return external_data_use_observer_->GetExternalDataUseReporterForTesting(); 141 return external_data_use_observer_->GetExternalDataUseReporterForTesting();
139 } 142 }
140 143
(...skipping 403 matching lines...) Expand 10 before | Expand all | Expand 10 after
544 EXPECT_EQ( 547 EXPECT_EQ(
545 base::TimeDelta::FromMilliseconds(kDefaultMaxDataReportSubmitWaitMsec), 548 base::TimeDelta::FromMilliseconds(kDefaultMaxDataReportSubmitWaitMsec),
546 external_data_use_reporter()->data_report_submit_timeout_); 549 external_data_use_reporter()->data_report_submit_timeout_);
547 EXPECT_EQ(kDataUseReportMinBytes, 550 EXPECT_EQ(kDataUseReportMinBytes,
548 external_data_use_reporter()->data_use_report_min_bytes_); 551 external_data_use_reporter()->data_use_report_min_bytes_);
549 } 552 }
550 553
551 } // namespace android 554 } // namespace android
552 555
553 } // namespace chrome 556 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/browser/android/data_usage/external_data_use_reporter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698