Batch data use objects in ExternalDataUseObserver

chrome/browser/android/data_usage/external_data_use_observer.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_DATA_USAGE_EXTERNAL_DATA_USE_OBSERVER_H_
 #define CHROME_BROWSER_ANDROID_DATA_USAGE_EXTERNAL_DATA_USE_OBSERVER_H_
 
+#include <deque>
+#include <memory>
+
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "base/threading/thread_checker.h"
 #include "base/time/time.h"
 #include "components/data_usage/core/data_use_aggregator.h"
 
 namespace base {
 class SingleThreadTaskRunner;
@@ skipping 66 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest,
                            PeriodicFetchMatchingRules);
   FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest,
                            RegisteredAsDataUseObserver);
   FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, Variations);
   FRIEND_TEST_ALL_PREFIXES(DataUseUITabModelTest, ReportTabEventsTest);
 
   // data_usage::DataUseAggregator::Observer implementation:
   void OnDataUse(const data_usage::DataUse& data_use) override;
 
+  // Called when a batch of data use objects are added to |data_use_list|.

[tbansal1, 2016/07/21 04:40:30]

s/list/list_/

[Raj, 2016/07/21 05:58:22]

Done.

+  void OnDataUseBatchComplete();
+
   // Aggregator that sends data use observations to |this|.
   data_usage::DataUseAggregator* data_use_aggregator_;
 
   // |external_data_use_observer_bridge_| is owned by |this|, and interacts with
   // the Java code. It is created on IO thread but afterwards, should only be
   // accessed on UI thread.
   ExternalDataUseObserverBridge* external_data_use_observer_bridge_;
 
   // Maintains tab sessions and is owned by |this|. It is created on IO thread
   // but afterwards, should only be accessed on UI thread.
   DataUseTabModel* data_use_tab_model_;
 
   // Labels, buffers and reports the data usage. It is owned by |this|. It is
   // created on IO thread but afterwards, should only be accessed on UI thread.
   ExternalDataUseReporter* external_data_use_reporter_;
 
+  // Batches the data use objects reported by DataUseAggregator.
+  std::unique_ptr<std::deque<const data_usage::DataUse>> data_use_list;

[tbansal1, 2016/07/21 04:40:30]

s/list/list_/

[tbansal1, 2016/07/21 04:40:30]

Add a comment that when this variable is null, it means ..... When it is
non-null, it means...

[Raj, 2016/07/21 05:58:22]

Done.

[Raj, 2016/07/21 05:58:22]

Done.

+
+  // |io_task_runner_| is used to call methods on IO thread.
+  scoped_refptr<base::SingleThreadTaskRunner> io_task_runner_;
+
   // |ui_task_runner_| is used to call methods on UI thread.
   scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;
 
   // Time when the matching rules were last fetched.
   base::TimeTicks last_matching_rules_fetch_time_;
 
   // Duration after which matching rules are periodically fetched.
   const base::TimeDelta fetch_matching_rules_duration_;
 
   // True if |this| is currently registered as a data use observer.
   bool registered_as_data_use_observer_;
 
   base::ThreadChecker thread_checker_;
 
   base::WeakPtrFactory<ExternalDataUseObserver> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ExternalDataUseObserver);
 };
 
 }  // namespace android
 
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_ANDROID_DATA_USAGE_EXTERNAL_DATA_USE_OBSERVER_H_