Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Issue 2169763002: Reland of "Mojo interface/service for Leak Detector on remote process" (Closed)

Created:
4 years, 5 months ago by Simon Que
Modified:
4 years, 5 months ago
CC:
Aaron Boodman, abarth-chromium, asvitkine+watch_chromium.org, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of "Mojo interface/service for Leak Detector on remote process" This interface allows an instance of the Runtime Memory Leak Detector (components/metrics/leak_detector) to run on a non-browser process, such as a tab (renderer) process. The interface provides two function APIs: - GetParams(): Returns the profiling parameters used for initializing LeakDetector. - SendLeakReports(): Passes an array of leak reports to the browser process, where they can be attached to the UMA protobuf. Also added an implementation of the Mojo interface, LeakDetectorRemoteController, that implements the Mojo interface LeakDetectorRemote. This class provides a bridge between the browser and renderer processes. It also allows a single instance of LeakDetectorController to provide leak detector params to the renderer process and receive leak reports from the renderer process. ============================================== Fixes since previous commit: - Add missing dependency to components_unittests GYP build - Add dependency on Mojo C++ services code to renderer BUG=chromium:615223 TEST=Build successfully, unit tests pass R=wfh@chromium.org Review-Url: https://codereview.chromium.org/2064463002 Committed: https://crrev.com/0e57a1efd2a6f47e492c7d990eb397dfab5402a0 Cr-Original-Commit-Position: refs/heads/master@{#406466} Cr-Commit-Position: refs/heads/master@{#406959}

Patch Set 1 #

Patch Set 2 : Add missing dependency to components_unittests GYP build #

Patch Set 3 : Add dependency on Mojo C++ services code to renderer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+691 lines, -61 lines) Patch
M chrome/app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/metrics/leak_detector/leak_detector_controller.h View 3 chunks +16 lines, -1 line 0 comments Download
M chrome/browser/metrics/leak_detector/leak_detector_controller.cc View 1 chunk +27 lines, -6 lines 0 comments Download
A chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h View 1 chunk +66 lines, -0 lines 0 comments Download
A chrome/browser/metrics/leak_detector/leak_detector_remote_controller.cc View 1 chunk +71 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/chrome_renderer.gypi View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/renderer/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/renderer/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/renderer/leak_detector/BUILD.gn View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A chrome/renderer/leak_detector/leak_detector_remote_client.h View 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/renderer/leak_detector/leak_detector_remote_client.cc View 1 chunk +55 lines, -0 lines 0 comments Download
M components/components_tests.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download
M components/metrics.gypi View 1 chunk +12 lines, -0 lines 0 comments Download
M components/metrics/BUILD.gn View 3 chunks +1 line, -52 lines 0 comments Download
A components/metrics/leak_detector/BUILD.gn View 1 chunk +65 lines, -0 lines 0 comments Download
M components/metrics/leak_detector/OWNERS View 1 chunk +5 lines, -0 lines 0 comments Download
A components/metrics/leak_detector/leak_detector.mojom View 1 chunk +40 lines, -0 lines 0 comments Download
A components/metrics/leak_detector/protobuf_to_mojo_converter.h View 1 chunk +36 lines, -0 lines 0 comments Download
A components/metrics/leak_detector/protobuf_to_mojo_converter.cc View 1 chunk +67 lines, -0 lines 0 comments Download
A components/metrics/leak_detector/protobuf_to_mojo_converter_unittest.cc View 1 chunk +139 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (16 generated)
Simon Que
4 years, 5 months ago (2016-07-21 06:59:42 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-21 08:29:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169763002/60001
4 years, 5 months ago (2016-07-21 16:09:38 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/222406)
4 years, 5 months ago (2016-07-21 16:15:56 UTC) #14
Simon Que
4 years, 5 months ago (2016-07-21 17:20:50 UTC) #16
Ilya Sherman
lgtm
4 years, 5 months ago (2016-07-21 20:42:30 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169763002/60001
4 years, 5 months ago (2016-07-21 21:05:46 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/222698)
4 years, 5 months ago (2016-07-21 21:14:23 UTC) #21
Will Harris
lgtm
4 years, 5 months ago (2016-07-21 21:43:59 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169763002/60001
4 years, 5 months ago (2016-07-21 21:45:09 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 5 months ago (2016-07-21 21:53:25 UTC) #26
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 21:55:21 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0e57a1efd2a6f47e492c7d990eb397dfab5402a0
Cr-Commit-Position: refs/heads/master@{#406959}

Powered by Google App Engine
This is Rietveld 408576698