Makes WebAPK handle NOTIFICATION_PREFERENCES intents

Makes WebAPK handle NOTIFICATION_PREFERENCES intents

This CL makes WebAPK handle NOTIFICATION_PREFERENCES intents. The intent is
forwarded to the host browser. A NOTIFICATION_PREFERENCES intent is sent
when the user long presses on a notification on L+ and taps on the "gear icon".

BUG=610156
Committed: https://crrev.com/349039d03080d2ebc81f5e136d64804e99b43d49
Cr-Commit-Position: refs/heads/master@{#407631}

[pkotwicz, 2016-07-21 02:08:26]

pkotwicz@chromium.org changed reviewers:
+ yfriedman@chromium.org

[pkotwicz, 2016-07-21 02:08:27]

Yaron can you please take a look?

[Yaron, 2016-07-21 15:56:41]

full review pending question on the bug

https://codereview.chromium.org/2169743002/diff/1/chrome/android/webapk/shell...
File
chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/NotificationSettingsLauncherActivity.java
(right):

https://codereview.chromium.org/2169743002/diff/1/chrome/android/webapk/shell...
chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/NotificationSettingsLauncherActivity.java:25:
return;
you should probably finish() this activty (also after startActivity())

[pkotwicz, 2016-07-23 00:39:40]

Yaron can you please take another look? I have replied to the bug

[Yaron, 2016-07-25 14:28:27]

https://codereview.chromium.org/2169743002/diff/20001/chrome/android/webapk/s...
File chrome/android/webapk/shell_apk/AndroidManifest.xml (right):

https://codereview.chromium.org/2169743002/diff/20001/chrome/android/webapk/s...
chrome/android/webapk/shell_apk/AndroidManifest.xml:40: <meta-data
android:name="hostNotificationPreferencesHandler"
I'm thinking that it would be nice to limit the number of new manifest fields we
introduce. If we do need to add them, then we should try and add them with some
generality to try and limit the number of variables. This would make it easier
to push new versions and not depend on new server releases (to populate those
variables).

Since this will be rare, it's ok to me if it's not the most optimal. Can we
instead add logic to the runtime_library to scan the host browser's manifest for
a NOTIFICATION_PREFERENCES handler and intent to that? Or is that even necessary
- could you just send this intent (act=android.intent.action.MAIN,
cat=android.intent.category.NOTIFICATION_PREFERENCES) at the host browser
package?

Alternatively, we could add a "MainActivity" class. Then a requirement for
webapk host is that your main activity must be able to handle this intent.

[pkotwicz, 2016-07-25 18:23:25]

Yaron, can you please take another look?

https://codereview.chromium.org/2169743002/diff/20001/chrome/android/webapk/s...
File chrome/android/webapk/shell_apk/AndroidManifest.xml (right):

https://codereview.chromium.org/2169743002/diff/20001/chrome/android/webapk/s...
chrome/android/webapk/shell_apk/AndroidManifest.xml:40: <meta-data
android:name="hostNotificationPreferencesHandler"
I changed the intent to be sent solely to the browser package. It seems to work

[Yaron, 2016-07-25 18:25:17]

On 2016/07/25 18:23:25, pkotwicz wrote:
> Yaron, can you please take another look?
> 
>
https://codereview.chromium.org/2169743002/diff/20001/chrome/android/webapk/s...
> File chrome/android/webapk/shell_apk/AndroidManifest.xml (right):
> 
>
https://codereview.chromium.org/2169743002/diff/20001/chrome/android/webapk/s...
> chrome/android/webapk/shell_apk/AndroidManifest.xml:40: <meta-data
> android:name="hostNotificationPreferencesHandler"
> I changed the intent to be sent solely to the browser package. It seems to
work

[Yaron, 2016-07-25 18:25:27]

lgtm!

[Yaron, 2016-07-25 18:26:00]

On 2016/07/25 18:25:27, Yaron wrote:
> lgtm!

err - is there any way to tell which webapk is redirecting the intent? may want
to add it as an extra if not

[pkotwicz, 2016-07-25 18:37:09]

There is no way to tell which WebAPK is redirecting the intent. There is logic
right now of getting the notification origin from the intent
(NotificationPlatformBridge#launchNotificationPreferences()). If the origin is
provided then the settings page for that origin is opened. We can use this
information to figure out which WebAPK redirected the intent.

[Yaron, 2016-07-25 19:11:49]

On 2016/07/25 18:37:09, pkotwicz wrote:
> There is no way to tell which WebAPK is redirecting the intent. There is logic
> right now of getting the notification origin from the intent
> (NotificationPlatformBridge#launchNotificationPreferences()). If the origin is
> provided then the settings page for that origin is opened. We can use this
> information to figure out which WebAPK redirected the intent.

so do webapk notifications also set the tag it expects? I assume yes based on
the fact that we're largely reusing the notification logic?

[pkotwicz, 2016-07-25 19:24:00]

Yes, WebAPK notifications also set the tag that Chrome expects. The Android
framework sets the tag not Chrome. I believe that the Android framework takes
the tag from the intent sent in WebApkServiceImpl#notifyNotification()

[pkotwicz, 2016-07-25 19:24:12]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-07-25 19:24:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yaron, 2016-07-25 19:31:22]

On 2016/07/25 19:24:48, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

makes sense, thanks!

[commit-bot: I haz the power, 2016-07-25 21:27:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 21:27:03]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pkotwicz, 2016-07-25 22:35:00]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-07-25 22:35:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 23:33:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-25 23:35:33]

Description was changed from

==========
Makes WebAPK handle NOTIFICATION_PREFERENCES intents

This CL makes WebAPK handle NOTIFICATION_PREFERENCES intents. The intent is
forwarded to the host browser. A NOTIFICATION_PREFERENCES intent is sent
when the user long presses on a notification on L+ and taps on the "gear icon".

BUG=610156
==========

to

==========
Makes WebAPK handle NOTIFICATION_PREFERENCES intents

This CL makes WebAPK handle NOTIFICATION_PREFERENCES intents. The intent is
forwarded to the host browser. A NOTIFICATION_PREFERENCES intent is sent
when the user long presses on a notification on L+ and taps on the "gear icon".

BUG=610156

Committed: https://crrev.com/349039d03080d2ebc81f5e136d64804e99b43d49
Cr-Commit-Position: refs/heads/master@{#407631}
==========

[commit-bot: I haz the power, 2016-07-25 23:35:34]

Patchset 3 (id:??) landed as
https://crrev.com/349039d03080d2ebc81f5e136d64804e99b43d49
Cr-Commit-Position: refs/heads/master@{#407631}