Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2169733002:
ozone: Let BGRA fullscreen overlays replace primary plane. (Closed)
|
Created:
4 years, 5 months ago by Daniele Castagna Modified:
4 years, 5 months ago CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org, reveman Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionozone: Let BGRA fullscreen overlays replace primary plane.
Ozone HardwareDisplayPlaneManager has an internal optimization where
if an overlay completely covers the primary plane and it doesn't have an
alpha channel it is used to replace the primary plane.
Chrome promotes to overlays only RGBA buffers that don't use blending.
This CL relaxes the costraint that the buffer has to XBGR to use this
optimization.
BUG=b/29430506
Committed: https://crrev.com/a3a1976dfe5630881dc8a2748666a4132326e481
Cr-Commit-Position: refs/heads/master@{#406934}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Comment about alpha blending not needed. #Messages
Total messages: 25 (16 generated)
The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== ozone: Let BGRA fullscreen overlays to replace primary plane. Ozone HardwareDisplayPlaneManager has an internal optimization where if an overlay completely covers the primary plane and it doesn't have an alpha channel it is used to replace the primary plane. Chrome promotes to overlays only RGBA buffers that don't use blending. This CL relaxes the costraint that the buffer has to XBGR to use this optimization. BUG=b/29430506 ========== to ========== ozone: Let BGRA fullscreen overlays replace primary plane. Ozone HardwareDisplayPlaneManager has an internal optimization where if an overlay completely covers the primary plane and it doesn't have an alpha channel it is used to replace the primary plane. Chrome promotes to overlays only RGBA buffers that don't use blending. This CL relaxes the costraint that the buffer has to XBGR to use this optimization. BUG=b/29430506 ==========
dcastagna@chromium.org changed reviewers: + dnicoara@chromium.org
reveman@chromium.org changed reviewers: + reveman@chromium.org
https://codereview.chromium.org/2169733002/diff/1/ui/ozone/platform/drm/gpu/h... File ui/ozone/platform/drm/gpu/hardware_display_plane_manager.cc (right): https://codereview.chromium.org/2169733002/diff/1/ui/ozone/platform/drm/gpu/h... ui/ozone/platform/drm/gpu/hardware_display_plane_manager.cc:270: fourcc_format == DRM_FORMAT_ARGB8888) && nit: can you add a comment here explaining that ARGB buffer will only arrive here if blending is not needed
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm with reveman's nit
The CQ bit was checked by dcastagna@chromium.org to run a CQ dry run
https://codereview.chromium.org/2169733002/diff/1/ui/ozone/platform/drm/gpu/h... File ui/ozone/platform/drm/gpu/hardware_display_plane_manager.cc (right): https://codereview.chromium.org/2169733002/diff/1/ui/ozone/platform/drm/gpu/h... ui/ozone/platform/drm/gpu/hardware_display_plane_manager.cc:270: fourcc_format == DRM_FORMAT_ARGB8888) && On 2016/07/21 at 01:45:36, reveman wrote: > nit: can you add a comment here explaining that ARGB buffer will only arrive here if blending is not needed Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
The CQ bit was checked by dcastagna@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dnicoara@chromium.org Link to the patchset: https://codereview.chromium.org/2169733002/#ps20001 (title: "Comment about alpha blending not needed.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
The CQ bit was checked by dcastagna@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== ozone: Let BGRA fullscreen overlays replace primary plane. Ozone HardwareDisplayPlaneManager has an internal optimization where if an overlay completely covers the primary plane and it doesn't have an alpha channel it is used to replace the primary plane. Chrome promotes to overlays only RGBA buffers that don't use blending. This CL relaxes the costraint that the buffer has to XBGR to use this optimization. BUG=b/29430506 ========== to ========== ozone: Let BGRA fullscreen overlays replace primary plane. Ozone HardwareDisplayPlaneManager has an internal optimization where if an overlay completely covers the primary plane and it doesn't have an alpha channel it is used to replace the primary plane. Chrome promotes to overlays only RGBA buffers that don't use blending. This CL relaxes the costraint that the buffer has to XBGR to use this optimization. BUG=b/29430506 Committed: https://crrev.com/a3a1976dfe5630881dc8a2748666a4132326e481 Cr-Commit-Position: refs/heads/master@{#406934} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a3a1976dfe5630881dc8a2748666a4132326e481 Cr-Commit-Position: refs/heads/master@{#406934} |
