Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 216973004: DevTools: roll CodeMirror to v4.0.3 (Closed)

Created:
6 years, 9 months ago by lushnikov
Modified:
6 years, 8 months ago
Reviewers:
apavlov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: roll CodeMirror to v4.0.3 This patch rolls codemirror to version 4.0.3. It also rolls all supporting plugins we use, though leaving highlighting modes intact. BUG=356878 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170462

Patch Set 1 #

Patch Set 2 : support autocomplete with multiselections #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3407 lines, -1953 lines) Patch
M Source/devtools/front_end/CodeMirrorTextEditor.js View 1 13 chunks +84 lines, -36 lines 0 comments Download
M Source/devtools/front_end/CodeMirrorUtils.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/cm/closebrackets.js View 3 chunks +95 lines, -38 lines 0 comments Download
M Source/devtools/front_end/cm/codemirror.css View 7 chunks +24 lines, -17 lines 0 comments Download
M Source/devtools/front_end/cm/codemirror.js View 193 chunks +3078 lines, -1796 lines 0 comments Download
M Source/devtools/front_end/cm/comment.js View 5 chunks +30 lines, -6 lines 0 comments Download
M Source/devtools/front_end/cm/headlesscodemirror.js View 2 chunks +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/cm/markselection.js View 4 chunks +16 lines, -9 lines 0 comments Download
M Source/devtools/front_end/cm/matchbrackets.js View 2 chunks +74 lines, -48 lines 0 comments Download
M Source/devtools/front_end/externs.js View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
lushnikov
please, take a look
6 years, 9 months ago (2014-03-28 21:51:31 UTC) #1
pfeldman
lgtm
6 years, 8 months ago (2014-03-31 12:03:07 UTC) #2
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 8 months ago (2014-03-31 13:21:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/216973004/20001
6 years, 8 months ago (2014-03-31 13:22:05 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-31 13:51:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-03-31 13:51:03 UTC) #6
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 8 months ago (2014-03-31 14:11:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/216973004/20001
6 years, 8 months ago (2014-03-31 14:11:49 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-31 15:12:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-03-31 15:12:17 UTC) #10
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 8 months ago (2014-03-31 16:04:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/216973004/20001
6 years, 8 months ago (2014-03-31 16:04:44 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 16:55:56 UTC) #13
Message was sent while issue was closed.
Change committed as 170462

Powered by Google App Engine
This is Rietveld 408576698