ios/web/web_state/ui/crw_web_controller.mm - Issue 2169703002: [ios] Do not signal finish load if currentURL != lastRegisteredURL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 2169703002: [ios] Do not signal finish load if currentURL != lastRegisteredURL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/web/web_state/ui/crw_web_controller.mm

diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm

index f45749e6e3cd635dcd527f879cc0896cf582089d..78b1223671231fd648178602d6e1dd634b859942 100644

--- a/ios/web/web_state/ui/crw_web_controller.mm

+++ b/ios/web/web_state/ui/crw_web_controller.mm

@@ -5323,10 +5323,13 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;

[self webPageChanged];

}

- // Fast back forward navigation does not call |didFinishNavigation:|, so

- // signal did finish navigation explicitly.

[self updateSSLStatusForCurrentNavigationItem];

- [self didFinishNavigation];

+ // Fast back forward navigation may not call |didFinishNavigation:|, so

+ // signal did finish navigation explicitly.

+ if (_lastRegisteredRequestURL == _documentURL) {

+ [self didFinishNavigation];

+ }

}

- (void)webViewTitleDidChange {

« no previous file with comments | « no previous file | no next file » | no next file with comments »