Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2169703002: [ios] Do not signal finish load if currentURL != lastRegisteredURL. (Closed)

Created:
4 years, 5 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 4 months ago
Reviewers:
kkhorimoto, justincohen
CC:
chromium-reviews, justincohen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Do not signal finish load if currentURL != lastRegisteredURL. If user navigates forward and then immidiately back the following sequence of events happens: 1.) ForwardURL is registered for load 2.) BackURL is registered for load 3.) Loading is stopped and current web view URL is ForwardURL 4.) Did Finish Loading is called and current web view URL is BackURL On step 3 web should not signal didFinishLoad if current web view URL != last registered URL, because telling embedder that load has finished for ForwardURL is false information. BUG=629565 Committed: https://crrev.com/34984eef64a1363a53055e1e696e6a9c9eaefb33 Cr-Commit-Position: refs/heads/master@{#407686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Eugene But (OOO till 7-30)
4 years, 5 months ago (2016-07-21 00:59:02 UTC) #4
kkhorimoto
lgtm
4 years, 4 months ago (2016-07-26 00:48:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169703002/1
4 years, 4 months ago (2016-07-26 01:40:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 02:15:54 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 02:19:12 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34984eef64a1363a53055e1e696e6a9c9eaefb33
Cr-Commit-Position: refs/heads/master@{#407686}

Powered by Google App Engine
This is Rietveld 408576698