Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2169683002: Flip many of the remaining Mac GYP builders to GN. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, erikchen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip many of the remaining Mac GYP builders to GN. This flips most (but not all) of the remaining Mac GYP builders to GN: - chromium.fyi - Chromium Mac 10.10 MacViews - Chromium Mac 10.11 - Chromium Mac 10.11 Force Mac Toolchain - Chromium Mac 10.9 Goma Canary - Chromium Mac 10.9 Goma Canary (clobber) - Chromium Mac 10.9 Goma Canary (dbg) - Chromium Mac 10.9 Goma Canary (dbg)(clobber) - ClangToTMac - ClangToTMac (dbg) - tryserver.chromium.mac: - mac_chromium_10.10_macviews There are still some GYP builders on chromium.perf and chromium.lkgr, but this CL is big enough as-is. R=rsesek@chromium.org BUG=618468 Committed: https://crrev.com/d3b350b39b0f2f79881778f6c026ad7dd6c12432 Cr-Commit-Position: refs/heads/master@{#406917}

Patch Set 1 #

Patch Set 2 : keep the asan builders on gyp for now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -26 lines) Patch
M tools/mb/mb_config.pyl View 1 8 chunks +18 lines, -26 lines 0 comments Download

Messages

Total messages: 24 (15 generated)
Dirk Pranke
4 years, 5 months ago (2016-07-21 01:12:13 UTC) #2
Robert Sesek
I don't think ASAN on Mac is ready yet. All the rest are, though.
4 years, 5 months ago (2016-07-21 16:02:05 UTC) #7
Dirk Pranke
Okay, dropping the asan builders. Also, I'm going to skip the macview trybot because it ...
4 years, 5 months ago (2016-07-21 17:07:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169683002/20001
4 years, 5 months ago (2016-07-21 17:08:07 UTC) #11
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-21 17:08:09 UTC) #13
Robert Sesek
lgtm
4 years, 5 months ago (2016-07-21 18:33:41 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169683002/20001
4 years, 5 months ago (2016-07-21 18:34:34 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 18:41:27 UTC) #22
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 18:42:57 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d3b350b39b0f2f79881778f6c026ad7dd6c12432
Cr-Commit-Position: refs/heads/master@{#406917}

Powered by Google App Engine
This is Rietveld 408576698