|
|
Created:
4 years, 5 months ago by Dirk Pranke Modified:
4 years, 5 months ago Reviewers:
Robert Sesek CC:
chromium-reviews, erikchen Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFlip many of the remaining Mac GYP builders to GN.
This flips most (but not all) of the remaining Mac GYP builders
to GN:
- chromium.fyi
- Chromium Mac 10.10 MacViews
- Chromium Mac 10.11
- Chromium Mac 10.11 Force Mac Toolchain
- Chromium Mac 10.9 Goma Canary
- Chromium Mac 10.9 Goma Canary (clobber)
- Chromium Mac 10.9 Goma Canary (dbg)
- Chromium Mac 10.9 Goma Canary (dbg)(clobber)
- ClangToTMac
- ClangToTMac (dbg)
- tryserver.chromium.mac:
- mac_chromium_10.10_macviews
There are still some GYP builders on chromium.perf and chromium.lkgr,
but this CL is big enough as-is.
R=rsesek@chromium.org
BUG=618468
Committed: https://crrev.com/d3b350b39b0f2f79881778f6c026ad7dd6c12432
Cr-Commit-Position: refs/heads/master@{#406917}
Patch Set 1 #Patch Set 2 : keep the asan builders on gyp for now #Messages
Total messages: 24 (15 generated)
Description was changed from ========== Flip many of the remaining Mac GYP builders to GN. This flips most (but not all) of the remaining Mac GYP builders to GN: - chromium.fyi - Chromium Mac 10.10 MacViews - Chromium Mac 10.11 - Chromium Mac 10.11 Force Mac Toolchain - Chromium Mac 10.9 Goma Canary - Chromium Mac 10.9 Goma Canary (clobber) - Chromium Mac 10.9 Goma Canary (dbg) - Chromium Mac 10.9 Goma Canary (dbg)(clobber) - ClangToTMac - ClangToTMac (dbg) - ClangToTMacASan - chromium.memory: - Mac ASAN 64 Builder - tryserver.chromium.mac: - mac_chromium_10.10_macviews - mac_chromium_asan_rel_ng There are still some GYP builders on chromium.perf and chromium.lkgr, but this CL is big enough as-is. R=rsesek@chromium.org BUG=618468 ========== to ========== Flip many of the remaining Mac GYP builders to GN. This flips most (but not all) of the remaining Mac GYP builders to GN: - chromium.fyi - Chromium Mac 10.10 MacViews - Chromium Mac 10.11 - Chromium Mac 10.11 Force Mac Toolchain - Chromium Mac 10.9 Goma Canary - Chromium Mac 10.9 Goma Canary (clobber) - Chromium Mac 10.9 Goma Canary (dbg) - Chromium Mac 10.9 Goma Canary (dbg)(clobber) - ClangToTMac - ClangToTMac (dbg) - ClangToTMacASan - chromium.memory: - Mac ASAN 64 Builder - tryserver.chromium.mac: - mac_chromium_10.10_macviews - mac_chromium_asan_rel_ng There are still some GYP builders on chromium.perf and chromium.lkgr, but this CL is big enough as-is. R=rsesek@chromium.org BUG=618468 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_10.10_macviews,mac_chromium_asan_rel_ng ==========
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
I don't think ASAN on Mac is ready yet. All the rest are, though.
Description was changed from ========== Flip many of the remaining Mac GYP builders to GN. This flips most (but not all) of the remaining Mac GYP builders to GN: - chromium.fyi - Chromium Mac 10.10 MacViews - Chromium Mac 10.11 - Chromium Mac 10.11 Force Mac Toolchain - Chromium Mac 10.9 Goma Canary - Chromium Mac 10.9 Goma Canary (clobber) - Chromium Mac 10.9 Goma Canary (dbg) - Chromium Mac 10.9 Goma Canary (dbg)(clobber) - ClangToTMac - ClangToTMac (dbg) - ClangToTMacASan - chromium.memory: - Mac ASAN 64 Builder - tryserver.chromium.mac: - mac_chromium_10.10_macviews - mac_chromium_asan_rel_ng There are still some GYP builders on chromium.perf and chromium.lkgr, but this CL is big enough as-is. R=rsesek@chromium.org BUG=618468 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_10.10_macviews,mac_chromium_asan_rel_ng ========== to ========== Flip many of the remaining Mac GYP builders to GN. This flips most (but not all) of the remaining Mac GYP builders to GN: - chromium.fyi - Chromium Mac 10.10 MacViews - Chromium Mac 10.11 - Chromium Mac 10.11 Force Mac Toolchain - Chromium Mac 10.9 Goma Canary - Chromium Mac 10.9 Goma Canary (clobber) - Chromium Mac 10.9 Goma Canary (dbg) - Chromium Mac 10.9 Goma Canary (dbg)(clobber) - ClangToTMac - ClangToTMac (dbg) - tryserver.chromium.mac: - mac_chromium_10.10_macviews There are still some GYP builders on chromium.perf and chromium.lkgr, but this CL is big enough as-is. R=rsesek@chromium.org BUG=618468 ==========
Okay, dropping the asan builders. Also, I'm going to skip the macview trybot because it looked like something went horribly wrong there.
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Flip many of the remaining Mac GYP builders to GN. This flips most (but not all) of the remaining Mac GYP builders to GN: - chromium.fyi - Chromium Mac 10.10 MacViews - Chromium Mac 10.11 - Chromium Mac 10.11 Force Mac Toolchain - Chromium Mac 10.9 Goma Canary - Chromium Mac 10.9 Goma Canary (clobber) - Chromium Mac 10.9 Goma Canary (dbg) - Chromium Mac 10.9 Goma Canary (dbg)(clobber) - ClangToTMac - ClangToTMac (dbg) - tryserver.chromium.mac: - mac_chromium_10.10_macviews There are still some GYP builders on chromium.perf and chromium.lkgr, but this CL is big enough as-is. R=rsesek@chromium.org BUG=618468 ========== to ========== Flip many of the remaining Mac GYP builders to GN. This flips most (but not all) of the remaining Mac GYP builders to GN: - chromium.fyi - Chromium Mac 10.10 MacViews - Chromium Mac 10.11 - Chromium Mac 10.11 Force Mac Toolchain - Chromium Mac 10.9 Goma Canary - Chromium Mac 10.9 Goma Canary (clobber) - Chromium Mac 10.9 Goma Canary (dbg) - Chromium Mac 10.9 Goma Canary (dbg)(clobber) - ClangToTMac - ClangToTMac (dbg) - tryserver.chromium.mac: - mac_chromium_10.10_macviews There are still some GYP builders on chromium.perf and chromium.lkgr, but this CL is big enough as-is. R=rsesek@chromium.org BUG=618468 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Flip many of the remaining Mac GYP builders to GN. This flips most (but not all) of the remaining Mac GYP builders to GN: - chromium.fyi - Chromium Mac 10.10 MacViews - Chromium Mac 10.11 - Chromium Mac 10.11 Force Mac Toolchain - Chromium Mac 10.9 Goma Canary - Chromium Mac 10.9 Goma Canary (clobber) - Chromium Mac 10.9 Goma Canary (dbg) - Chromium Mac 10.9 Goma Canary (dbg)(clobber) - ClangToTMac - ClangToTMac (dbg) - tryserver.chromium.mac: - mac_chromium_10.10_macviews There are still some GYP builders on chromium.perf and chromium.lkgr, but this CL is big enough as-is. R=rsesek@chromium.org BUG=618468 ========== to ========== Flip many of the remaining Mac GYP builders to GN. This flips most (but not all) of the remaining Mac GYP builders to GN: - chromium.fyi - Chromium Mac 10.10 MacViews - Chromium Mac 10.11 - Chromium Mac 10.11 Force Mac Toolchain - Chromium Mac 10.9 Goma Canary - Chromium Mac 10.9 Goma Canary (clobber) - Chromium Mac 10.9 Goma Canary (dbg) - Chromium Mac 10.9 Goma Canary (dbg)(clobber) - ClangToTMac - ClangToTMac (dbg) - tryserver.chromium.mac: - mac_chromium_10.10_macviews There are still some GYP builders on chromium.perf and chromium.lkgr, but this CL is big enough as-is. R=rsesek@chromium.org BUG=618468 Committed: https://crrev.com/d3b350b39b0f2f79881778f6c026ad7dd6c12432 Cr-Commit-Position: refs/heads/master@{#406917} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/d3b350b39b0f2f79881778f6c026ad7dd6c12432 Cr-Commit-Position: refs/heads/master@{#406917} |