Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2169653002: mash: Move shelf_navigator.* to //ash/common/shelf (Closed)

Created:
4 years, 5 months ago by James Cook
Modified:
4 years, 5 months ago
Reviewers:
msw
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Move shelf_navigator.* to //ash/common/shelf Mechanical move, no functional changes BUG=615155 TEST=compiles Committed: https://crrev.com/7296812a9d2829283a16c918b05b0f7b42f5940c Cr-Commit-Position: refs/heads/master@{#406700}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -238 lines) Patch
M ash/ash.gyp View 1 4 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/shelf/shelf_navigator.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/shelf/shelf_navigator.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/shelf/shelf_navigator_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M ash/shelf/shelf.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D ash/shelf/shelf_navigator.h View 1 chunk +0 lines, -23 lines 0 comments Download
D ash/shelf/shelf_navigator.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D ash/shelf/shelf_navigator_unittest.cc View 1 chunk +0 lines, -132 lines 0 comments Download
M ash/shelf/shelf_widget.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
James Cook
msw, please take a look.
4 years, 5 months ago (2016-07-20 21:51:29 UTC) #5
msw
lgtm with a nit https://codereview.chromium.org/2169653002/diff/1/ash/shelf/shelf_widget.cc File ash/shelf/shelf_widget.cc (right): https://codereview.chromium.org/2169653002/diff/1/ash/shelf/shelf_widget.cc#newcode15 ash/shelf/shelf_widget.cc:15: #include "ash/common/shelf/shelf_navigator.h" nit: not needed?
4 years, 5 months ago (2016-07-20 21:55:30 UTC) #8
James Cook
https://codereview.chromium.org/2169653002/diff/1/ash/shelf/shelf_widget.cc File ash/shelf/shelf_widget.cc (right): https://codereview.chromium.org/2169653002/diff/1/ash/shelf/shelf_widget.cc#newcode15 ash/shelf/shelf_widget.cc:15: #include "ash/common/shelf/shelf_navigator.h" On 2016/07/20 21:55:30, msw wrote: > nit: ...
4 years, 5 months ago (2016-07-20 21:58:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169653002/40001
4 years, 5 months ago (2016-07-20 22:00:52 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-20 22:45:50 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 22:47:08 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7296812a9d2829283a16c918b05b0f7b42f5940c
Cr-Commit-Position: refs/heads/master@{#406700}

Powered by Google App Engine
This is Rietveld 408576698