Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2169633004: Fix GetPlatformImageColor on macOS Sierra. (Closed)

Created:
4 years, 5 months ago by erikchen
Modified:
4 years, 5 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, rsesek+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GetPlatformImageColor on macOS Sierra. This test method was assuming that the output from NSReadPixel was in deviceRGBColorSpace, which is not necessarily true in macOS Sierra. BUG=629706 Committed: https://crrev.com/e1b5537dde1744629675522db737175ffcf978a4 Cr-Commit-Position: refs/heads/master@{#406921}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/gfx/image/image_unittest_util_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
erikchen
rsesek: Please review.
4 years, 5 months ago (2016-07-21 17:01:04 UTC) #3
Robert Sesek
lgtm
4 years, 5 months ago (2016-07-21 18:44:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169633004/1
4 years, 5 months ago (2016-07-21 18:45:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 18:50:15 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 18:51:50 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1b5537dde1744629675522db737175ffcf978a4
Cr-Commit-Position: refs/heads/master@{#406921}

Powered by Google App Engine
This is Rietveld 408576698