Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 216963002: Add missing lazy deopt point for the TransitionElementsKind instruction. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2327 matching lines...) Expand 10 before | Expand all | Expand 10 after
2338 ASSERT(instr->value()->representation().IsTagged()); 2338 ASSERT(instr->value()->representation().IsTagged());
2339 2339
2340 LStoreKeyedGeneric* result = 2340 LStoreKeyedGeneric* result =
2341 new(zone()) LStoreKeyedGeneric(context, object, key, value); 2341 new(zone()) LStoreKeyedGeneric(context, object, key, value);
2342 return MarkAsCall(result, instr); 2342 return MarkAsCall(result, instr);
2343 } 2343 }
2344 2344
2345 2345
2346 LInstruction* LChunkBuilder::DoTransitionElementsKind( 2346 LInstruction* LChunkBuilder::DoTransitionElementsKind(
2347 HTransitionElementsKind* instr) { 2347 HTransitionElementsKind* instr) {
2348 LOperand* object = UseRegister(instr->object());
2349 if (IsSimpleMapChangeTransition(instr->from_kind(), instr->to_kind())) { 2348 if (IsSimpleMapChangeTransition(instr->from_kind(), instr->to_kind())) {
2350 LOperand* object = UseRegister(instr->object()); 2349 LOperand* object = UseRegister(instr->object());
2351 LOperand* new_map_reg = TempRegister(); 2350 LOperand* new_map_reg = TempRegister();
2352 LOperand* temp_reg = TempRegister(); 2351 LOperand* temp_reg = TempRegister();
2353 LTransitionElementsKind* result = 2352 LTransitionElementsKind* result =
2354 new(zone()) LTransitionElementsKind(object, NULL, 2353 new(zone()) LTransitionElementsKind(object, NULL,
2355 new_map_reg, temp_reg); 2354 new_map_reg, temp_reg);
2356 return result; 2355 return result;
2357 } else { 2356 } else {
2357 LOperand* object = UseFixed(instr->object(), eax);
2358 LOperand* context = UseFixed(instr->context(), esi); 2358 LOperand* context = UseFixed(instr->context(), esi);
2359 LTransitionElementsKind* result = 2359 LTransitionElementsKind* result =
2360 new(zone()) LTransitionElementsKind(object, context, NULL, NULL); 2360 new(zone()) LTransitionElementsKind(object, context, NULL, NULL);
2361 return AssignPointerMap(result); 2361 return MarkAsCall(result, instr);
2362 } 2362 }
2363 } 2363 }
2364 2364
2365 2365
2366 LInstruction* LChunkBuilder::DoTrapAllocationMemento( 2366 LInstruction* LChunkBuilder::DoTrapAllocationMemento(
2367 HTrapAllocationMemento* instr) { 2367 HTrapAllocationMemento* instr) {
2368 LOperand* object = UseRegister(instr->object()); 2368 LOperand* object = UseRegister(instr->object());
2369 LOperand* temp = TempRegister(); 2369 LOperand* temp = TempRegister();
2370 LTrapAllocationMemento* result = 2370 LTrapAllocationMemento* result =
2371 new(zone()) LTrapAllocationMemento(object, temp); 2371 new(zone()) LTrapAllocationMemento(object, temp);
(...skipping 330 matching lines...) Expand 10 before | Expand all | Expand 10 after
2702 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2702 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2703 LOperand* object = UseRegister(instr->object()); 2703 LOperand* object = UseRegister(instr->object());
2704 LOperand* index = UseTempRegister(instr->index()); 2704 LOperand* index = UseTempRegister(instr->index());
2705 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2705 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2706 } 2706 }
2707 2707
2708 2708
2709 } } // namespace v8::internal 2709 } } // namespace v8::internal
2710 2710
2711 #endif // V8_TARGET_ARCH_IA32 2711 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698