Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 2169593003: Rename the chrome/browser/ui/app_modal directory to be javascript_dialogs. (Closed)

Created:
4 years, 5 months ago by Avi (use Gerrit)
Modified:
4 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename the chrome/browser/ui/app_modal directory to be javascript_dialogs. It will be the future home of the JavaScript dialog tab helper code, which will not be app-modal, so the name is no longer appropriate for use. In addition, I'm the owner of the existing dialog code (components/app_modal) so I'm going to claim ownership of the new code. BUG=629964 TEST=none Committed: https://crrev.com/175a82c72429ec5799455abafe70694be6654ebe Cr-Commit-Position: refs/heads/master@{#406920}

Patch Set 1 #

Patch Set 2 : owner #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -28 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/javascript_app_modal_dialog_android.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/app_modal/chrome_javascript_native_dialog_factory.h View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/javascript_dialogs/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/ui/javascript_dialogs/chrome_javascript_native_dialog_factory.h View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 11 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Avi (use Gerrit)
4 years, 5 months ago (2016-07-20 21:40:25 UTC) #7
jam
lgtm
4 years, 5 months ago (2016-07-21 16:15:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169593003/20001
4 years, 5 months ago (2016-07-21 18:42:28 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 18:47:46 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 18:49:30 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/175a82c72429ec5799455abafe70694be6654ebe
Cr-Commit-Position: refs/heads/master@{#406920}

Powered by Google App Engine
This is Rietveld 408576698