Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 2169583002: Eliminate SpdyHeaderBlock copy in SpdyStream. (Closed)

Created:
4 years, 5 months ago by Bence
Modified:
4 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate SpdyHeaderBlock copy in SpdyStream. Eliminate one SpdyHeaderBlock copy in SpdyStream::ProduceSynStreamFrame() (soon to be renamed ProduceHeaderFrame). This is achived by saving the GURL as soon as request_headers_ are set. Note that |url_| is not necessarily the same as url_from_header_block_, see, for example, SpdyHttpStreamTest.SpdyURLTest. Also remove test-only SpdyStream::HasUrlFromHeaders(). BUG=621905 Committed: https://crrev.com/da23393bc3adbd89f2ed5b57c1ad59def33c3ef1 Cr-Commit-Position: refs/heads/master@{#407055}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -125 lines) Patch
M net/spdy/spdy_session_pool_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_session_unittest.cc View 54 chunks +0 lines, -71 lines 0 comments Download
M net/spdy/spdy_stream.h View 2 chunks +4 lines, -14 lines 0 comments Download
M net/spdy/spdy_stream.cc View 4 chunks +4 lines, -12 lines 0 comments Download
M net/spdy/spdy_stream_unittest.cc View 15 chunks +13 lines, -27 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Bence
Ryan: PTAL. Thank you.
4 years, 5 months ago (2016-07-21 00:39:40 UTC) #6
Ryan Hamilton
lgtm nice!
4 years, 5 months ago (2016-07-21 22:15:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169583002/1
4 years, 5 months ago (2016-07-21 23:00:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 03:59:24 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 04:02:11 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da23393bc3adbd89f2ed5b57c1ad59def33c3ef1
Cr-Commit-Position: refs/heads/master@{#407055}

Powered by Google App Engine
This is Rietveld 408576698