Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Issue 2169563003: Revert of Remove stack overflow boilerplate (Closed)

Created:
4 years, 5 months ago by jgruber
Modified:
4 years, 5 months ago
Reviewers:
Yang, Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Remove stack overflow boilerplate (patchset #3 id:40001 of https://codereview.chromium.org/2161953003/ ) Reason for revert: Clusterfuzz failures in parent CL https://codereview.chromium.org/2142933003/ Original issue's description: > Remove stack overflow boilerplate > > We no longer need to prepare the stack overflow error in advance now that > Errors are constructed in C++. > > R=yangguo@chromium.org > BUG= > > Committed: https://crrev.com/ba95d10ccbe13e2fca427228483b045576f2dc4c > Cr-Commit-Position: refs/heads/master@{#37923} TBR=yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/c4ef8a8d6e52fc2f434654ab4934c2dc73411047 Cr-Commit-Position: refs/heads/master@{#37927}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -102 lines) Patch
M src/builtins/builtins-error.cc View 4 chunks +48 lines, -8 lines 0 comments Download
M src/contexts.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/isolate.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/isolate.cc View 7 chunks +36 lines, -29 lines 0 comments Download
M src/js/messages.js View 2 chunks +5 lines, -0 lines 0 comments Download
M src/messages.h View 1 chunk +0 lines, -15 lines 0 comments Download
M src/messages.cc View 2 chunks +0 lines, -47 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
jgruber
Created Revert of Remove stack overflow boilerplate
4 years, 5 months ago (2016-07-21 08:54:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169563003/1
4 years, 5 months ago (2016-07-21 08:54:34 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-07-21 08:54:35 UTC) #5
Michael Achenbach
lgtm
4 years, 5 months ago (2016-07-21 09:07:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2169563003/1
4 years, 5 months ago (2016-07-21 09:07:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 09:07:36 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 09:10:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4ef8a8d6e52fc2f434654ab4934c2dc73411047
Cr-Commit-Position: refs/heads/master@{#37927}

Powered by Google App Engine
This is Rietveld 408576698