Properly throw java exceptions from shouldOverrideUrlLoading

base/BUILD.gn

Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index ddb9ab4c9ce1057de5988ef1efc9db585e18bf5b..290c2873306cf7edc694d029e56d6337f33f6b48 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -514,6 +514,8 @@ component("base") {
     "message_loop/message_pump_mac.mm",
     "message_loop/message_pump_win.cc",
     "message_loop/message_pump_win.h",
+    "message_loop/test_system_message_handler_link_android.cc",
+    "message_loop/test_system_message_handler_link_android.h",
     "metrics/bucket_ranges.cc",
     "metrics/bucket_ranges.h",
     "metrics/field_trial.cc",
@@ -2025,6 +2027,7 @@ test("base_unittests") {
     deps += [
       ":base_java",
       ":base_java_unittest_support",
+      ":base_native_unittest_support",
       "//base/android/jni_generator:jni_generator_tests",
     ]
   }
@@ -2198,6 +2201,7 @@ if (is_android) {
       "android/java/src/org/chromium/base/PowerMonitor.java",
       "android/java/src/org/chromium/base/SysUtils.java",
       "android/java/src/org/chromium/base/SystemMessageHandler.java",
+      "android/java/src/org/chromium/base/TestSystemMessageHandler.java",
       "android/java/src/org/chromium/base/ThreadUtils.java",
       "android/java/src/org/chromium/base/TraceEvent.java",
       "android/java/src/org/chromium/base/library_loader/LibraryLoader.java",
@@ -2270,6 +2274,7 @@ if (is_android) {
       "android/java/src/org/chromium/base/StreamUtil.java",
       "android/java/src/org/chromium/base/SysUtils.java",
       "android/java/src/org/chromium/base/SystemMessageHandler.java",
+      "android/java/src/org/chromium/base/TestSystemMessageHandler.java",
       "android/java/src/org/chromium/base/ThreadUtils.java",
       "android/java/src/org/chromium/base/TraceEvent.java",
       "android/java/src/org/chromium/base/VisibleForTesting.java",
@@ -2439,4 +2444,15 @@ if (is_android) {
     java_files =
         [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ]
   }
+
+  component("base_native_unittest_support") {

[nyquist, 2016/08/16 17:46:39]

Did you mean for this to be a source_set?

[gsennton, 2016/08/17 17:05:47]

yeah, I've removed this completely and put the files under base/test/ instead
(in the library named "test_support"

+    sources = [
+      "android/java_handler_thread_for_testing.cc",
+      "android/java_handler_thread_for_testing.h",
+    ]
+
+    deps = [
+      ":base",
+    ]
+  }
 }