Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1812)

Unified Diff: base/android/java_handler_thread.h

Issue 2169553002: Properly throw java exceptions from shouldOverrideUrlLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Better separation of production and test code, and minor cleanups. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/java_handler_thread.h
diff --git a/base/android/java_handler_thread.h b/base/android/java_handler_thread.h
index 1709ff4fce8c72bc9619cb87130dd06ceea62949..d54bcc7276acda5d5f0069aa1c114108f27b238a 100644
--- a/base/android/java_handler_thread.h
+++ b/base/android/java_handler_thread.h
@@ -30,16 +30,25 @@ class BASE_EXPORT JavaHandlerThread {
base::MessageLoop* message_loop() const { return message_loop_.get(); }
void Start();
+ void StartForTesting(base::WaitableEvent* test_done_event);
void Stop();
+ void StopForTesting();
// Called from java on the newly created thread.
// Start() will not return before this methods has finished.
void InitializeThread(JNIEnv* env,
const JavaParamRef<jobject>& obj,
jlong event);
+ void InitializeThreadForTesting(JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ jlong event,
+ jlong test_done_event);
void StopThread(JNIEnv* env,
const JavaParamRef<jobject>& obj,
jlong event);
+ void StopThreadForTesting(JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ jlong event);
static bool RegisterBindings(JNIEnv* env);

Powered by Google App Engine
This is Rietveld 408576698