android_webview/browser/aw_content_browser_client.cc - Issue 2169553002: Properly throw java exceptions from shouldOverrideUrlLoading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_content_browser_client.cc

Issue 2169553002: Properly throw java exceptions from shouldOverrideUrlLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Better separation of production and test code, and minor cleanups. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java » ('j') | base/message_loop/message_loop_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/aw_content_browser_client.cc

diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc

index a6ce29ec13e083cf8ff085445a4cfaae4befa089..ffafc030858bd4685898a4a328e57f510528b091 100644

--- a/android_webview/browser/aw_content_browser_client.cc

+++ b/android_webview/browser/aw_content_browser_client.cc

@@ -128,6 +128,8 @@ void AwContentsMessageFilter::OnShouldOverrideUrlLoading(

if (client) {

*ignore_navigation = client->ShouldOverrideUrlLoading(

url, has_user_gesture, is_redirect, is_main_frame);

+ // If the shouldOverrideUrlLoading call caused a java exception we should

+ // always return immediately here!

} else {

LOG(WARNING) << "Failed to find the associated render view host for url: "

<< url;