base/BUILD.gn - Issue 2169553002: Properly throw java exceptions from shouldOverrideUrlLoading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/BUILD.gn

Issue 2169553002: Properly throw java exceptions from shouldOverrideUrlLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix trybot compilation failure. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/native/aw_contents_client_bridge.cc ('k') | base/android/java/src/org/chromium/base/SystemMessageHandler.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/BUILD.gn

diff --git a/base/BUILD.gn b/base/BUILD.gn

index 1ab2217a02fdc0b269339adcf4daddc405b429eb..09cb143dfb7aa31063eadf98368a308d80885c17 100644

--- a/base/BUILD.gn

+++ b/base/BUILD.gn

@@ -177,6 +177,7 @@ component("base") {

"android/important_file_writer_android.h",

"android/java_handler_thread.cc",

"android/java_handler_thread.h",

+ "android/java_message_handler_factory.h",

"android/java_runtime.cc",

"android/java_runtime.h",

"android/jni_android.cc",

@@ -2018,7 +2019,7 @@ test("base_unittests") {

":i18n",

":message_loop_tests",

"//base/allocator:features",

- "//base/test:run_all_unittests",

+ "//base/test:run_all_base_unittests",

"//base/test:test_support",

"//base/third_party/dynamic_annotations",

"//testing/gmock",

@@ -2459,7 +2460,9 @@ if (is_android) {

deps = [

":base_java",

]

- java_files =

- [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ]

+ java_files = [

+ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java",

+ "test/android/java/src/org/chromium/base/TestSystemMessageHandler.java",

+ ]

}