Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: android_webview/browser/aw_content_browser_client.cc

Issue 2169553002: Properly throw java exceptions from shouldOverrideUrlLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix trybot compilation failure. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/aw_content_browser_client.cc
diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc
index df161d1dd6975c87b7e6bbf2219af52930c58e60..ff00820da9e4a0720f0027055df1956d60ff8487 100644
--- a/android_webview/browser/aw_content_browser_client.cc
+++ b/android_webview/browser/aw_content_browser_client.cc
@@ -130,6 +130,8 @@ void AwContentsMessageFilter::OnShouldOverrideUrlLoading(
if (client) {
*ignore_navigation = client->ShouldOverrideUrlLoading(
url, has_user_gesture, is_redirect, is_main_frame);
+ // If the shouldOverrideUrlLoading call caused a java exception we should
+ // always return immediately here!
} else {
LOG(WARNING) << "Failed to find the associated render view host for url: "
<< url;
« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698