Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: base/BUILD.gn

Issue 2169553002: Properly throw java exceptions from shouldOverrideUrlLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused includes in test_support_android.cc. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index 1ab2217a02fdc0b269339adcf4daddc405b429eb..38fa9949324b88ce5c9eb4319143e3f67033aa2e 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -177,6 +177,7 @@ component("base") {
"android/important_file_writer_android.h",
"android/java_handler_thread.cc",
"android/java_handler_thread.h",
+ "android/java_message_handler_factory.h",
"android/java_runtime.cc",
"android/java_runtime.h",
"android/jni_android.cc",
@@ -2017,8 +2018,8 @@ test("base_unittests") {
":base",
":i18n",
":message_loop_tests",
+ "//base:run_all_base_unittests",
"//base/allocator:features",
- "//base/test:run_all_unittests",
"//base/test:test_support",
"//base/third_party/dynamic_annotations",
"//testing/gmock",
@@ -2194,6 +2195,16 @@ if (enable_nocompile_tests) {
}
}
+static_library("run_all_base_unittests") {
danakj 2016/08/18 17:50:16 Please move this to base/test/BUILD.gn
gsennton 2016/08/18 18:56:54 Done.
+ testonly = true
+ sources = [
+ "run_all_base_unittests.cc",
+ ]
+ deps = [
+ "//base/test:test_support",
+ ]
+}
+
if (is_android) {
# GYP: //base.gyp:base_jni_headers
generate_jni("base_jni_headers") {
@@ -2459,7 +2470,9 @@ if (is_android) {
deps = [
":base_java",
]
- java_files =
- [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ]
+ java_files = [
+ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java",
+ "test/android/java/src/org/chromium/base/TestSystemMessageHandler.java",
+ ]
}
}

Powered by Google App Engine
This is Rietveld 408576698