android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java - Issue 2169553002: Properly throw java exceptions from shouldOverrideUrlLoading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

Issue 2169553002: Properly throw java exceptions from shouldOverrideUrlLoading (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unused includes in test_support_android.cc. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/aw_content_browser_client.cc ('k') | android_webview/native/aw_contents_client_bridge.cc » ('j') | android_webview/native/aw_contents_client_bridge.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java b/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

index 8c29c2d93c5da1bc281558729b6c53251bc49a72..cbfb616d335387e30f1924583568025454cc776d 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

@@ -12,6 +12,7 @@ import android.webkit.ValueCallback;

import org.chromium.base.ThreadUtils;

import org.chromium.base.annotations.CalledByNative;

+import org.chromium.base.annotations.CalledByNativeUnchecked;

import org.chromium.base.annotations.JNINamespace;

import java.security.Principal;

@@ -250,7 +251,7 @@ public class AwContentsClientBridge {

mClient.handleJsBeforeUnload(url, message, handler);

}

- @CalledByNative

+ @CalledByNativeUnchecked

private boolean shouldOverrideUrlLoading(

String url, boolean hasUserGesture, boolean isRedirect, boolean isMainFrame) {

return mClient.shouldIgnoreNavigation(