Properly throw java exceptions from shouldOverrideUrlLoading

base/android/java_message_handler_factory.h

Index: base/android/java_message_handler_factory.h
diff --git a/base/android/java_message_handler_factory.h b/base/android/java_message_handler_factory.h
new file mode 100644
index 0000000000000000000000000000000000000000..78b95bd9470e6639d177a0427b79cedfde17993c
--- /dev/null
+++ b/base/android/java_message_handler_factory.h
@@ -0,0 +1,38 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BASE_ANDROID_JAVA_MESSAGE_HANDLER_FACTORY_H_
+#define BASE_ANDROID_JAVA_MESSAGE_HANDLER_FACTORY_H_
+
+#include "base/android/scoped_java_ref.h"
+#include "base/message_loop/message_pump.h"
+
+namespace base {
+
+class MessagePumpForUI;
+
+namespace android {
+
+/**
+ * Factory for creating the Java-side system message handler - only used for
+ * testing.
+ */
+class JavaMessageHandlerFactory {
+ public:
+  JavaMessageHandlerFactory() {}

[danakj, 2016/08/17 18:40:15]

dont need this

[gsennton, 2016/08/17 19:23:46]

Done.

+  virtual ~JavaMessageHandlerFactory() {}
+  virtual base::android::ScopedJavaLocalRef<jobject> CreateMessageHandler(
+      JNIEnv* env,
+      base::MessagePump::Delegate* delegate,
+      MessagePumpForUI* message_pump,
+      WaitableEvent* test_done_event) = 0;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(JavaMessageHandlerFactory);

[danakj, 2016/08/17 18:40:15]

or this, for a pure virtual interface

[gsennton, 2016/08/17 19:23:46]

Done.

+};
+
+}  // namespace android
+}  // namespace base
+
+#endif  // BASE_ANDROID_JAVA_MESSAGE_HANDLER_FACTORY_H_