Properly throw java exceptions from shouldOverrideUrlLoading

base/message_loop/message_loop_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop/message_loop.h"
 #include "base/message_loop/message_loop_test.h"
 #include "base/pending_task.h"
 #include "base/posix/eintr_wrapper.h"
 #include "base/run_loop.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/test/test_simple_task_runner.h"
 #include "base/threading/platform_thread.h"
 #include "base/threading/thread.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "build/build_config.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
+#if defined(OS_ANDROID)
+#include "base/android/java_handler_thread.h"
+#include "base/android/jni_android.h"
+#endif
+
 #if defined(OS_WIN)
 #include "base/message_loop/message_pump_win.h"
 #include "base/process/memory.h"
 #include "base/strings/string16.h"
 #include "base/win/current_module.h"
 #include "base/win/scoped_handle.h"
 #endif
 
 namespace base {
 
@@ skipping 29 matching lines @@
 
  private:
   friend class RefCounted<Foo>;
 
   ~Foo() {}
 
   int test_count_;
   std::string result_;
 };
 
+#if defined(OS_ANDROID)
+void AbortMessagePump() {
+  JNIEnv* env = base::android::AttachCurrentThread();
+  jclass exception =
+      env->FindClass("org/chromium/base/SystemMessageHandler$TestException");
+
+  env->ThrowNew(exception,
+                "This is a test exception that should be caught in "
+                "SystemMessageHandler.handleMessage");
+  static_cast<base::MessageLoopForUI*>(base::MessageLoop::current())->Abort();
+}
+
+void RunTest_Abort_Dont_Run_More_Tasks(bool delayed) {

[danakj, 2016/08/15 18:29:59]

normally for CapitilizedNames you don't put _ between words.

[gsennton, 2016/08/16 15:27:36]

Done.

+  MessageLoop loop(MessageLoop::TYPE_JAVA);
+
+  WaitableEvent test_done_event(WaitableEvent::ResetPolicy::MANUAL,
+                                WaitableEvent::InitialState::NOT_SIGNALED);
+
+  std::unique_ptr<android::JavaHandlerThread> java_thread;
+  java_thread.reset(new android::JavaHandlerThread("yolo"));
+  java_thread->StartForTesting(&test_done_event);
+
+  if (delayed) {
+    java_thread->message_loop()->PostDelayedTask(
+        FROM_HERE, Bind(&AbortMessagePump), TimeDelta::FromMilliseconds(10));
+  } else {
+    java_thread->message_loop()->PostTask(FROM_HERE, Bind(&AbortMessagePump));
+  }
+
+  // Wait to ensure we didn't crash
+  test_done_event.Wait();
+
+  java_thread->StopForTesting();
+  java_thread.reset();
+}
+
+TEST(MessageLoopTest, Java_Exception_Abort) {
+  RunTest_Abort_Dont_Run_More_Tasks(false);
+}
+TEST(MessageLoopTest, Delayed_Java_Exception_Abort) {
+  RunTest_Abort_Dont_Run_More_Tasks(true);
+}
+#endif  // defined(OS_ANDROID)
+
 #if defined(OS_WIN)
 
 // This function runs slowly to simulate a large amount of work being done.
 static void SlowFunc(TimeDelta pause, int* quit_counter) {
     PlatformThread::Sleep(pause);
     if (--(*quit_counter) == 0)
       MessageLoop::current()->QuitWhenIdle();
 }
 
 // This function records the time when Run was called in a Time object, which is
@@ skipping 902 matching lines @@
 
   {
     std::string kThreadName("bar");
     base::Thread thread(kThreadName);
     ASSERT_TRUE(thread.StartAndWaitForTesting());
     EXPECT_EQ(kThreadName, thread.message_loop()->GetThreadName());
   }
 }
 
 }  // namespace base