Properly throw java exceptions from shouldOverrideUrlLoading

base/android/java_handler_thread.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/android/java_handler_thread.h"
 
 #include <jni.h>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
@@ skipping 43 matching lines @@
   // Wait for thread to shut down before returning.
   base::ThreadRestrictions::ScopedAllowWait wait_allowed;
   shutdown_event.Wait();
 }
 
 void JavaHandlerThread::InitializeThread(JNIEnv* env,
                                          const JavaParamRef<jobject>& obj,
                                          jlong event) {
   // TYPE_JAVA to get the Android java style message loop.
   message_loop_.reset(new base::MessageLoop(base::MessageLoop::TYPE_JAVA));
-  static_cast<MessageLoopForUI*>(message_loop_.get())->Start();
+  StartMessageLoop();
   reinterpret_cast<base::WaitableEvent*>(event)->Signal();
 }
 
 void JavaHandlerThread::StopThread(JNIEnv* env,
                                    const JavaParamRef<jobject>& obj,
                                    jlong event) {
+  StopMessageLoop();
+  reinterpret_cast<base::WaitableEvent*>(event)->Signal();
+}
+
+void JavaHandlerThread::StartMessageLoop() {
+  static_cast<MessageLoopForUI*>(message_loop_.get())->Start();
+}
+
+void JavaHandlerThread::StopMessageLoop() {
   static_cast<MessageLoopForUI*>(message_loop_.get())->QuitWhenIdle();
-  reinterpret_cast<base::WaitableEvent*>(event)->Signal();
 }
 
 // static
 bool JavaHandlerThread::RegisterBindings(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 } // namespace android
 } // namespace base